Closed (fixed)
Project:
SimpleFeed
Version:
5.x-2.2
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
28 Aug 2008 at 21:13 UTC
Updated:
10 Oct 2008 at 03:56 UTC
Jump to comment: Most recent file
We should improve the validate hook to actually determine if a feed exists at that URL. A typo or putting in the blogs main URL may not work with autodiscovery so we should ensure it is checked before being added for usability.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | t.patch | 5.98 KB | m3avrck |
| #5 | feed_validation.patch | 3.78 KB | Scott Reynolds |
| #3 | simplefeed.patch | 3.04 KB | Scott Reynolds |
Comments
Comment #1
m3avrck commentedThis should be further expanded to have a flag in the DB table that says "Feed not Found" so the fetching query doesn't have to check those EVERY SINGLE time.
That way feeds that no longer work don't slow down processing of other feeds.
There should be an admin > feeds page to see status of feeds, sortable by last update and feeds no longer working.
There should be a way for *helper* modules to be built to then perhaps notifiy user their feed isn't working.
Example:
Comment #2
m3avrck commentedWe can then remove the CSS file and showing that data on the feed node too for cleanup!
Comment #3
Scott Reynolds commentedso this simple patch adds a DB column to the simplefeed_feed table called error. It sets error column to 1 when $feed->error isset(). When finding feeds to process it checks to make sure error = 0. Also this patch adds an index to error column (it only has 2 values and it will only be used as a 'filter' therefore, index will make it faster).
it cut things down tremendously on my dev machine.
As far as creating that table you have there not sure on how to determine the new items added per update and update rate
And i think what would be far more interesting, is a simplefeed_log table that has for instance vid, msg. That way on node view or in this admin table, it could say vid ->"Added 5 items" or vid->"cUrl failed". It would provide a way to understand whats going on under the hood since everything is soo automatic
Comment #4
summit commentedSubscribing, greetings, Martijn
Comment #5
Scott Reynolds commentedHere is a better one as it contains the option for validation of feed on hook_validate()
It also contains the fix for: http://drupal.org/node/307686
Edit: the reason it contains both fixes is cause they end up overlapping. to do the validation of the feed you have to be able to fetch feedburner feeds. but if you don't want to commit something a patch for 2 issues at once, remove the header() stuff. two lines
Comment #6
Scott Reynolds commentedoops! need to add on simplefeed_update() set error = 0
Comment #7
m3avrck commentedThanks Scott, committed a slightly modified version of this to 5.x.
Comment #8
m3avrck commentedFixed in 5.x:
http://drupal.org/cvs?commit=142416
Fixed in 6.x:
http://drupal.org/cvs?commit=142421
Comment #9
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.