Namespace collision with _send callbacks

Having thought it over would it make sense to modify the messaging_sms_send function. We could pass in the params array a boolean i.e. call_send or some other name. Should default to true in the params list array and if we decide to set it to false then it will not call the sms_send function from the messaging and any other module that should implement the hook.

Would that be an acceptable patch for the issue?

/**
* Send message to multiple destinations
*
* This is just a wrapper for sms_send()
*/
function messaging_sms_send($destination, $message, $params = array('call_send' => true)) {
// This function takes an array of destinations so
if ($params['call_send']) {
return sms_send(array($destination), $message['subject'].$message['body']);
}
}

Above is how the function in messaging_sms would look.

The corresponding call from sms_send would just add to the options array call_send

function sms_send($number, $message, $options = array()) {
$gateway = sms_default_gateway();

$options['call_send'] = true; // setting so we do not recursively re-call this function.
foreach (module_implements('sms_send') as $module) {
$function = $module .'_sms_send';
$function($number, $message, $options, $gateway);
}

if (function_exists($gateway['send'])) {
$response = $gateway['send']($number, $message, $options);
}
return sms_handle_result($response, $number, $message);
}

Will

Thanks for the update, would think that changing the messaging module is probably not a good idea since i think the messaging_sms_send is in the format that is users i.e. messaging_email_send, etc.

Would you be open to renaming the hook hook_sms_pre_send since it is doing pre-processing before the actual sending of the sms message??

I think that would resolve the issue satisfactorily since the module relying on this would be easy to change.

Your call though, i have no problems which ever way you decide to go.

Jose

thank you for fixing the issue.