mail2web strips out too much text when trying to strip email client signatures/quote lines

josedanielestrada - August 30, 2008 - 01:32
Project:Mail Comment
Version:5.x-1.0-beta3
Component:Miscellaneous
Category:bug report
Priority:normal
Assigned:Ian Ward
Status:closed
Description

i'm using mail2web but for some reason it doesn't work. I follow all the steps, also i retrieve successfully the message, but when i reply from the mail nothing happend in the website. Somebody can help me with that?

#1

Ian Ward - August 31, 2008 - 17:49

Hi Jose,

Can you tell me what mail application you replied with (gmail, yahoo, outlook, thunderbird, etc.)? Can you confirm your mailhandler setup is working? Finally, are you running cron and/or retrieving the messages manually on the admin/content/mailhandler (retrieve) page (if not running cron and/or mailhandler is not configured to retrieve messages on cron for that mailbox)?

thanks
Ian

#2

josedanielestrada - September 5, 2008 - 22:37

Hi,

My aplication is in Google Apps and this is the configuration of the module mailhandler:

E-mail address: myemail@mysite.com
Second E-mail address: *empty*
Folder: INBOX
Mailbox domain:pop.gmail.com
Mailbox port:995
Mailbox username: myemail@mysite.com
Mailbox password: xxx
Extra commands: /ssl/novalidate-cert
Mime preference:Plain Text
Security: disable
Send error replies:Disabled
Cron processing:Enabled

the point is the messages don't appear until i run cron or "retrive" in maillhandler section. The most important the messages appear in the website without the body (content), the same happend when i check the suscription by email. I recive the notification of the reply, but the content is empty.

AttachmentSize
empty reply.jpg 38.08 KB
empty reply2.jpg 46.34 KB

#3

Ian Ward - September 8, 2008 - 12:42

Jose, can you check a few more things?

1) What do you see when you click "edit" on the comment in http://drupal.org/files/issues/empty%20reply.jpg that has no body?
2) What is your input format set at on the mailhandler mailbox? (go to admin/content/mailhandler/ and click on edit for that mailbox, and look at the last setting at the bottom - there is a "Input Format" radio selection)
3) What is your "Message body filter:" set at on /admin/messaging/settings ?

#4

josedanielestrada - September 8, 2008 - 14:58

Hi, thanks for your help.

1) When i click "edit" on the comment in, it has only <.d.i.v. d.i.r.=.".l.t.r." (without the dots, see screenshot)

2) the input format is "Messaging plain text".

3) "Messaging plain text" in the three options

thanks in advance

AttachmentSize
comment.jpg 5.8 KB

#5

Ian Ward - September 8, 2008 - 15:11

For the input format for mailhandler for that mailbox (not for messaging, you have that set correct) can you try switching to another input format?

#6

josedanielestrada - September 8, 2008 - 15:20

I tried "Filtered HTML", "Full HTML" and "Messaging plain text" and results are the same: <.d.i.v. .d.i.r.=.".l.t.r." (without the dots)

#7

josedanielestrada - September 10, 2008 - 03:22

any clue?

#8

Ian Ward - September 10, 2008 - 03:35
Title:mail2web doesn't work» mail2web strips out too much text when trying to strip email client signatures/quote lines
Assigned to:Anonymous» Ian Ward

Are you using Gmail to reply to the messages? This looks like a bug w/ overzealous/bad an preg_match when trying to strip out the remains of the signature/quote line that email clients stick in. I was able to get this to repeat while replying to messages via Gmail. Assigning to myself to fix. I've started to look how to rework this part of the code to a simpler solution, but it will be a few days or mid next week before it's rolled out into the dev version.

#9

josedanielestrada - September 11, 2008 - 22:00

Yes i'm using Google Apps. I hope you get a solution. If you need some help just let me know.

#10

Ian Ward - September 25, 2008 - 03:25
Status:active» fixed

This is fixed in the latest commit to the dev version, Drupal 5 only. I'll do Drupal 6 soon. I've implemented an input format that will replace anything that mail2web thinks should be stripped with a collapsed fieldset at the end of the comment - much like "show quoted text" in gmail's client. This ensures no accidental data loss from over-aggressive or inaccurate regexing for all the corner cases and different mail cilents.

Please test on a dev site if you're able. I'm aiming for new betas w/in the next week or two.

Ian

#11

josedanielestrada - September 29, 2008 - 07:00

Hi, Ian.

Where can i access the dev version of mail2web? in the CVS there is not a new commit since Fri Aug 8.

Thanks in advance.

--project followup subject--

Anonymous (not verified) - October 13, 2008 - 07:13

Automatically closed -- issue fixed for two weeks with no activity.

--project followup subject--

Anonymous (not verified) - October 13, 2008 - 07:25

Automatically closed -- issue fixed for two weeks with no activity.

#12

Anonymous (not verified) - October 13, 2008 - 07:31
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

#13

Ian Ward - October 16, 2008 - 12:56
Status:closed» needs review

There is now a new dev version to test out which should fix this issue. An input format is now used to simply hide the text instead of deleting it. Not all email signatures/junk will get stripped out because the regex is still focused on mainly two common signature patterns. Anyone who is able to test the dev version it would be great to get more feedback.

Thanks

#14

Ian Ward - October 16, 2008 - 12:57
Status:needs review» active

I will keep this active until resolution is confirmed.

#15

cglusky - January 18, 2009 - 17:02

Ian,
the problem i have with the filter approach is one of workflow(?). what happens if the person goes to the site and edits the post and the same filter is not available to them? in my testing of D6 you get an error that complains about no input filter being set. this is just thinking out loud mostly. i could just be thinking about it too hard.

i ended up putting the regex stuff back in my d6 version to strip the text. but i am also not supporting html email on my sites, so that is not a good solution either.

thought about trying flexifilter or customfilter so there is no need to support this code in mail2web, but that adds complexity to admin.

r,
c

#16

Ian Ward - January 27, 2009 - 16:31
Status:active» fixed

I am going to close this issue, please see my comment here http://drupal.org/node/349730#comment-1223209 and look for a release for both 5 and 6 by the end of this week. Please read the project page as well, which will discuss which versions of notifications/messaging you will need.

thanks
Ian

#17

System Message - February 10, 2009 - 16:40
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

#18

Ian Ward - November 16, 2009 - 18:08
Project:Mail to Web» Mail Comment
Version:5.x-1.0-beta1» 5.x-1.0-beta3

Switch to mailcomment project. Mail2web is now known as "mailcomment" due to a trademark issue with the name mail2web.

 
 

Drupal is a registered trademark of Dries Buytaert.