Closed (fixed)
Project:
Guestbook
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
30 Aug 2008 at 02:18 UTC
Updated:
30 Jan 2011 at 03:50 UTC
Jump to comment: Most recent file
Comments
Comment #1
pmlehtim commentedSame problem also in D6.
Comment #2
sun@all: Do you mean Panels integration or regular Guestbook pages?
Comment #3
pmlehtim commentedI use regular guestbook.
- "Site guestbook only" is selected.
- Posting settings -> Location of entry submission form: -> Separate page -> not working, it just ends up on top.
I had also some problems when installling module... I had to modify SQL to take default values away from the TEXT fields. It is said in MYSQL reference that BLOB and TEXT columns cannot have DEFAULT values.
I didn't tried newest dev version yet. I am still using version 6.x-2.x-dev (2008-Sep-11).
Comment #4
sunOT: Thanks, committed attached patch to both 6.x branches to remove default values for text columns.
I need to investigate this issue further. But patches are also welcome. :)
Comment #5
toniw commentedThis seems to be caused by function theme_guestbook_form_entry_form no longer being called, at least, the comment in the code seems to indicate that:
Since that function returns just the link to the guestbook form if 'separate page' is selected instead of the whole form, this is no longer done. Seems to me this should not be a decision that is to be made in a theming function anyway...
I fixed the problem for my site with the attached patch. It is not nice code, but it gets the work done. Maybe sun can massage it into well-behaving code :-)
Sorry for setting the version back to 5.x.2.x, but that is what I am using and that is what this patch is written against.
Comment #6
toniw commentedWhile adding a CAPTCHA to my guestbooks in order to fight spam I discovered that my fix in #5 does not work nicely together with the captcha module. I tweaked the code a little and now it works ok.
Comment #7
Golem07 commentedHi,
I have been searching the issues but could not find any other thread that deals with this issue. I am actually using the Panels integration (latest 2.x dev Guestbook)and would like to outsource the input form to a separate page. Has there been any progress for the D6 version?
Thx a lot in advance
Comment #8
Hetta commented#6 doesn't work against the d6 version - or, it does add a link "add guestbook entry", but clicking that link (which goes to /guestbook/0/form) doesn't do anything.
Comment #9
zmove commentedAny news about this issue ? I encounter the same problem on the latest 6-2.x dev version
Comment #10
sndo commentedThe same problem still exists on the latest 6.x-2.x-dev version.
Comment #11
KirstenLangholz commenteddito
Comment #12
travisimo commentedThis still hasn't been fixed. Please FIX!
Comment #13
sunCommitted a fix for this to HEAD.