Closed (won't fix)
Project:
Asset
Version:
5.x-1.0-rc1
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
30 Aug 2008 at 19:24 UTC
Updated:
1 Nov 2010 at 20:48 UTC
Jump to comment: Most recent file
Comments
Comment #1
wmostrey commentedWow this is amazing! Thank you so much for your work on this David! It would be so great if this could replace the asset_bonus module altogether, that would tie in perfectly with the future of the asset module.
Do you have the code for mp3, flv and swf support? If so it would be awesome if you could add it and re-send the module.
Comment #2
David Lesieur commentedI did not code anything for mp3, flv and swf, but it's true that it probably makes more sense (and should be pretty easy) to support those though jQuery Media as well.
Comment #3
wmostrey commentedI can't seem to get it to work for mp3 and flv/swf. Could you take a quick look? It generates a blank space of the defined size but the player itself doesn't show up.
Comment #4
David Lesieur commentedI did some tests... MP3 and FLV embedding works properly in a node (at least with JW Player as the player for MP3 and FLV), but doesn't work in the Asset Wizard. It is probably because we're missing the following little bit of JavaScript that is normally added by
jquery_media_add():In my jQuery Media settings, I have set my default players to '/jwplayer/player.swf', but without the above code jQuery Media will look for 'mediaplayer.swf'.
The last version you have posted was missing WMA support. I suppose it was removed by mistake, so I'm posting a version with WMA support back in. MP3 and FLV support are not fixed though.
Note: Relying on jQuery Media for MP3 embedding is somewhat less user-friendly than just enabling Asset Bonus because more configuration work is needed to get up and running (setting the player, possibly having to tweak the flashvars). Also, it looks like 1PixelOut doesn't readily work with jQuery Media.
Comment #5
wmostrey commented