test install profiles files
pp - August 31, 2008 - 09:30
| Project: | Coder |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | stella |
| Status: | needs review |
Description
I am developing an install pofile and I would like to check the coding style with coder module. There are no options to check install profiles at the moment.
#1
#2
Try out the attached patch.
Cheers,
Stella
#3
I used the patch. It works good. I saw a new group(Select specific profiles) The group contains all installed profil. (I was install all 6.x profil, and my install profile)
I saw correct code review. ("Coder found 1 projects, 2 files, 114 normal warnings" Pasqualle said me, my coding style is dirty... I see now, and I will correct it! ;))
Thanks!
pp
(short: It works, Thanks)
#4
duplicate file, see the picture... (I saw it after I corrected all errors)
#5
Hmmm I can't reproduce this on my test site.
#6
sorry, sorry, sorry I'm stupid... I made some changes in coder.module on codesprint. I used this wrong version.
The patch is good.
#7
t(' (core)')should be:
' ('. t('core') .')'string inside t() should not start or end with space, it is hard to translate correctly..
but this should be fixed with a different issue, as coder already uses this incorrectly
even created a new request for code style check: #304150: check string in t()
based on pp test, and my quick visual code review, this patch is ready to go
#8
Re-rolled the patch with the t() change suggested by Pasqualle.
Cheers,
Stella
#9
The patch was malformed, so I re-rolled it.
I'm wondering, where do custom and contrib install profiles live? This patch looks from them in /profiles. Can they live in other places?
I'm also wondering if the munging the {system} table names with the profile names might cause problems. Can we have an install profile with the same name as a module.
#10
Well the installation instructions for the install profiles I downloaded (e.g. Drupalbin) said to put them in the profiles/ directory, alongside profiles/default/. I also checked where install.php looks for the installation profiles. The function
install_find_profiles()just looks in the top level profiles/ directory :file_scan_directory('./profiles', '\.profile$', array('.', '..', 'CVS'), 0, TRUE, 'name', 0);Cheers,
Stella
#11
Yeah, I suppose there could be potential for name clashes between profiles and modules/themes. Maybe we could prepend the index name with 'coder_profile' or some such. Can take another look at it.