DBTNG blog.module

Unfortunatly it breaks blog API tests. See the attached picture.

Hmmz this is strange. I just did a new checkout and all the tests passed. Then I applied your patch and it still passed :S

The dblog test is failing because of the function _blog_post_exists. You typecast a object to boolean here._blog_post_exists

BlogAPI weirdness was here, now passes in head: http://drupal.org/node/297860

(this is why all tests should always pass).

Working on this as of the DrupalCon DC Code sprint... patch coming soon

OK. So all db_query functions and their counterparts have been converted to the new dynamic db_select syntax throughout the module. As a part of this I also rewrote node_title_list() to use a foreach loop instead of a while loop, as suggested by Crell.

Additionally, two chunks of code in blog.pages.inc could be shortened by simply doing a fetchCol() on the query instead of fetching a result and then looping through the results.

Do not use dynamic queries if you don't need dynamic behavior. It looks like you're converting all SELECT queries to dynamic, which is just a performance hit.

OK. What's the test for me to know which queries are dynamic and which are static?

First try writing the query as a static. If you find that you need to use one of:

- String concatenation
- Paging
- Tablesort
- Node access restrictions

Then stop and make it dynamic instead.

That's not a perfect rule, but that's a good guideline. The vast majority of queries will be static.

I would add to that ruleset: If you think there is a significant likelyhood that sites will want to alter the query to achieve custom needs, use db_select(). Static queries are not alterable.

Also, if a query currently uses db_rewrite_sql() then you must include '->addTag('node_access')'. Thats missing in a few places.

Reroll.. there were no candicates for static queries, just added addTag() a few times and changed the extend() coding style according to #425872: DX problem with DB extenders. I also "removed" the node_title_list() change from the patch... I think it's easier to convert module per module.

Patch chained a addExpression(1) call... replaced by fields('n', array('nid')).

Looks good, and all tests pass. Committed to CVS HEAD.