Some Array-Bugs in 5.x-1.3
Cybso - August 31, 2008 - 12:39
| Project: | Quickmenu |
| Version: | 5.x-1.3 |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | needs review |
Jump to:
Description
The quickmenu.info of 5.x contains wrong core version (6.x) and an errornous formated dependency-list ("[]" behind "dependencies"). This causes the module to have a dependency to "Array" and prevents the user from activating this module.
Another problem may also also affect 6.x, I don't looked at it. The code expects the result of "variable_get('quickmenu_enabled',2);" to be an array. I think you could solve this by consequently using "array(2)" as default parameter, but in this case I added some code to check wether the result is an array or not.
| Attachment | Size |
|---|---|
| quickmenu-5.x-1.3-array-0.patch | 2.18 KB |
#1
Confirm problems cited by Cybso.
I manually patched module version 5.x-1.3:
- Dependancy problem went away: this is crucial as module cannot be activated on Drupal 5 if this is not solved.
- Array: cannot tell the difference after patching because module was not active before. Anyway, module is working fine now.
I am using Drupal 5.11.
#2
I'm experiencing same problems on Drupal 5.12. I could not apply patch using gygwin (hunk failed at line 1) so I changed by hand and applied manually. Patch seems to work OK from initial testing. I'll post back if I find any probs.
Cheers.