Remove the themes property from the Drupal object in drupal.js
katbailey - August 31, 2008 - 13:01
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | javascript |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
The Drupal js object is initialised in misc/drupal.js with four properties, one of which is "themes". I think this is a remnant from the patch here: http://drupal.org/files/issues/js-localization.patch. The Drupal.theme function has since changed and no longer has any reference to Drupal.themes. The attached patch removes this property from the Drupal object initialisation as it can lead to confusion.
| Attachment | Size |
|---|---|
| drupal_js_patch.patch | 611 bytes |
| Testbed results | ||
|---|---|---|
| drupal_js_patch.patch | failed | Failed: Failed to install HEAD. a href=http://testing.drupal.org/pifr/file/1/drupal_js_patch.patchDetailed results/a |
#1
The last submitted patch failed testing.
#2
Patch re-rolled against HEAD.
#3
this patch still applies nice, i'm just wondering wether there is some documentation to change
#4
I'm pretty certain there is no reference to this themes property anywhere else. Somebody like kkaefer could confirm this though I think...
#5
I committed this to CVS HEAD. It looked valid.
#6
@katbailey: Yep you're right. Drupal.theme is now used instead of Drupal.themes.
#7
Automatically closed -- issue fixed for two weeks with no activity.