The Drupal js object is initialised in misc/drupal.js with four properties, one of which is "themes". I think this is a remnant from the patch here: http://drupal.org/files/issues/js-localization.patch. The Drupal.theme function has since changed and no longer has any reference to Drupal.themes. The attached patch removes this property from the Drupal object initialisation as it can lead to confusion.

CommentFileSizeAuthor
#2 drupal_js-302251.patch611 byteskatbailey
drupal_js_patch.patch611 byteskatbailey

Comments

Status: Needs review » Needs work

The last submitted patch failed testing.

katbailey’s picture

katbailey commented
Status: Needs work » Needs review
StatusFileSize
new drupal_js-302251.patch611 bytes

Patch re-rolled against HEAD.

dawehner’s picture

dawehner
Primary language German
commented

this patch still applies nice, i'm just wondering wether there is some documentation to change

katbailey’s picture

katbailey commented

I'm pretty certain there is no reference to this themes property anywhere else. Somebody like kkaefer could confirm this though I think...

dries’s picture

dries commented
Status: Needs review » Fixed

I committed this to CVS HEAD. It looked valid.

kkaefer’s picture

kkaefer commented

@katbailey: Yep you're right. Drupal.theme is now used instead of Drupal.themes.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.