Rework block.module for the new data api

OK, block_admin_display_form_submit() wasn't working simply because I had left out execute().

More thougths:

Crell says we should the default object fetch mode as much as possible. There are at least two places in this patch where I override that and use arrays, since it seemed like a pretty big job to change every occurrence of the retrieved variable from arrays to objects ($box and $old_block). So I wanted to check first to see if people think we should actually do that.

Also:

Since there are still few examples to look at I'm not sure how to format this code: chained method calls, wrapping long statements etc. I seem to remember Crell showing something similar to this:

<?php
db_update('blocks')->fields(array(
  'status' => $block['status'],
  'weight' => $block['weight'],
  'region' => $block['region'],
))->condition('module', $block['module'])->condition('delta', $block['delta'])->condition('theme', $block['theme'])->execute();
?>

...or even:

<?php
db_update('blocks')->fields(array(
  'status' => $block['status'],
  'weight' => $block['weight'],
  'region' => $block['region'],
))->condition(
  'module',
  $block['module']
)->condition(
  'delta',
  $block['delta']
)->condition(
  'theme',
  $block['theme']
)->execute();
?>

The fields array works good this way I think, but I don't particularly like the condition() clutter in any of these two examples. Thoughts?

I'll be back later with an updated patch.

Ah, so this it probably what we should do:

<?php
db_update('blocks')->fields(array(
  'status' => $block['status'],
  'weight' => $block['weight'],
  'region' => $block['region'],
))->condition('module', $block['module'])
  ->condition('delta', $block['delta'])
  ->condition('theme', $block['theme'])
  ->execute();
?>

Wasn't aware of that possibility. Looks a lot better.

Here comes a new patch. All tests pass!

It's been pretty easy to port this moule once I got the hang of it.

Just a couple of questions (as above):
– is db_last_insert_id() used in the new API?
– are there any query results that should be converted to objects (instead of using PDO::FETCH_ASSOC)?
– coding style OK?

Oh, and of course, there are still two complicated dynamic queries marked TODO.

Greetings from Drupalcamp Copenhagen!

Here is a new patch which is updated to reflect recent changes in HEAD, such as changed table names.
I also had to add a couple of (int) casts as PDO was complaining about wrong data types.

The TODO items are still there.

#337212: DBTNG: Block module