The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Could you port this great module to Drupal 6?
I can provide testing.
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | error_d6.png | 2.99 KB | francewhoa |
| #14 | feedback.info_.rej_.zip | 273 bytes | francewhoa |
| #15 | feedback[AFTER_PATCH_IN_10].zip | 20.85 KB | francewhoa |
| #15 | feedback[BEFORE_PATCH_IN_10].zip | 17.44 KB | francewhoa |
| #13 | error1.png | 3.57 KB | francewhoa |
Comments
Comment #1
tebb commentedsubscribing
Comment #2
sunThis patch should include almost all necessary changes for D6. Please test.
Upgrade path for D5 is missing (also in Journal module, btw).
Comment #3
francewhoasun: Thanks for the .patch
I would like to test it but applying a patch is beyond my skills. Could you post a tarball or a .zip file?
Comment #4
sunLook here: http://drupal.org/patch
Comment #5
francewhoasun: Thanks for the link.
I applied patch #2 against HEAD (feedback-5.x-2.x-dev.tar.gz). Patching is successful no error returned.
Patched module testing result: Drupal 6.4 module admin page says: 'This version is incompatible with the 6.4 version of Drupal core.' There's a red X and the module can't be activated.
Attached is a screenshot (.png) & the patched module (.zip). Hope this help.
Comment #6
francewhoaSame result with patch #2 against official releases (feedback-5.x-2.0.tar.gz).
Comment #7
pasqualle1. you need to change (or remove) the version string in the info file
2. you have to add core="6.x" into the info file
Comment #8
koorneef commentedPatch applies, module works. but I was hoping this module could be called from within a menu. Instead it is present at all pages.
Comment #9
pasqualleif it works then it is RTBC
@koorneef: you can create a new feature request..
Comment #10
sunMissed to replace admin/logs paths with admin/reports.
Also, an upgrade path, just like the example in http://api.drupal.org/api/function/db_change_field/6, is still missing.
Comment #11
anoopjohn commentedCan you please start a development branch for drupal 6 with the patch applied on the 5.x code so that people can start downloading and test the 6.x version.
Comment #12
Flying Drupalist commentedsubscribe
Comment #13
francewhoa@sun: The patch in comment #10 is against which version?
I tried to apply it against current HEAD 5.x-2.x-dev (2008-Sep-08) but it returns the following error:
Hunk #1 FAILED at 3.Attached is error screenshot. Plus the .rej file.
Have you tried the module Deadwood?: The purpose of this module is to automate as much as possible the task of updating a contributed module for Drupal API changes, and thereby simplify the task of porting contributed modules shortly after a new Drupal release.
Comment #14
francewhoa@sun: I tried to apply the patch in #10 against feedback-6.x-1.x-dev.tar.gz (September 29, 2008) but it returns the same following error:
Hunk #1 FAILED at 3.Attached is error screenshot. Plus the .rej file. Hope this help.
Comment #15
francewhoa@all: If someone else want to help with testing here is the current development version of Feedback module for Drupal 6:
HEAD Drupal 6.x versions here at the bottom of the page. For testing only. Do not use on production website only test website.
Comment #16
encho commentedSubscribing
Comment #17
Babalu commentedsubscribing
Comment #18
sunI have committed the latest patch now.
However, I hope that all of you have read the project page and you are aware of Feedback 2.x being a completely different module than 1.x. Development on 1.x is discontinued.
The current development snapshot for 6.x displays a wrong version number, and will hopefully be fixed soon.
Comment #19
sunOww... I just realized that we still need to remove the module dependency on jquery_update, since D6 already ships with the required jQuery version.
Comment #20
Flying Drupalist commentedThis module is under 'development' in the module list right? If it is it's giving me:
This version is incompatible with the 6.4 version of Drupal core.
Comment #21
Flying Drupalist commentedHi, this is still the case for 6.5
Comment #22
sunI've removed the dependency on jQuery Update module now, which was also the cause for the big red error sign. A new development snapshot should be available in approx. 12 hours.
Comment #23
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.