This is comment and taxonomy test, no change at all just copy paste. More granular tests let you pick which to run, when running all you can make them more parallel, slower machines do not time out...

CommentFileSizeAuthor
#9 unappaproved.patch1.48 KBcatch
#7 testslices_0.patch18.17 KBcatch
#6 testslices.patch18.17 KBchx
testslices.patch18.17 KBchx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chx’s picture

chx CreditAttribution: chx commented
Component: database system » tests
Category: bug » task
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented

No time to test now but just a quick note that in #296009: TestingParty08: Comment signatures I moved postComment out to drupal_web_test_case and made the signature test it's own class. I agree with this in general, not sure myself where postComment should live, but worth mentioning.

Damien Tournoud’s picture

Damien Tournoud CreditAttribution: Damien Tournoud commented

I would love to see postComment being part of CommentHelperCase and the Comment signature test be a subclass of that. That would be awesome.

Robin Monks’s picture

Robin Monks CreditAttribution: Robin Monks commented
Status: Needs review » Reviewed & tested by the community

It seems like a solid patch, and the tests (comment and taxonomy) ran fine, "533 passes, 0 fails, 0 exceptions". Looks good to me. Not sure what will happen with #2 and #3, but, the patch does work.

Robin

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Needs work

The description of CommentAnonymous is not valid. Other descriptions might need double-checking too.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Reviewed & tested by the community
FileSize
testslices.patch18.17 KB

Fixed the descriptions , and read all of them.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
FileSize
testslices_0.patch18.17 KB

Fixed a spelling error which was in the original test but not caught by the split. Read through everything and it seems reasonable. There's a lot more cleanup of comment.test could be done - but we can do that in other patches.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Priority: Normal » Critical
Status: Fixed » Needs review
FileSize
unappaproved.patch1.48 KB

Now it's my turn to break tests :(

Call to undefined method CommentApprovalTest::getUnaprovedComment().

Sorry.

Damien Tournoud’s picture

Damien Tournoud CreditAttribution: Damien Tournoud commented
Status: Needs review » Reviewed & tested by the community

Good lord :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Hehe. Committed. ;)

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.