Is it safe to download and use a more recen bad-behavior.x.x.xx.zip?
Carlos Miranda Levy - September 1, 2008 - 23:23
| Project: | Bad Behavior |
| Version: | 5.x-2.0-beta1 |
| Component: | Code |
| Category: | support request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Description
There are several newer versions available for download at http://www.bad-behavior.ioerror.us/download/
Is it safe to use them or should we stick with bad-behavior-2.0.13.zip mentioned in the installation instructions?
#1
The answer is, it is not.
The module does not work with the latest .zip file available for download at http://www.bad-behavior.ioerror.us/download/
It works though with the version listed in the module's instructions.
#2
I'd argue with this.
Look at diff between 2.0.13 and 2.0.23: http://dpaste.com/hold/80665/
It contains only fixes and no schema changes.
Only file deleted was admin.inc.php and it is not included (at least in drupal 5.x branch).
At least it works fine for me.
#3
i'm using 2.0.23 with no problems..
*Edit 11/21/08: no, i wasnt using 2.0.23 like i thought.. and when i upgraded to 2.0.25 logging stopped - but applying the patch posted below fixed it right up..
#4
there is a change there that breaks the logging.
diff -ru 2_13/bad-behavior/core.inc.php 2_23/bad-behavior/core.inc.php
--- 2_13/bad-behavior/core.inc.php 2008-09-26 13:52:11.000000000 +0300
+++ 2_23/bad-behavior/core.inc.php 2008-09-26 13:52:53.000000000 +0300
@@ -80,7 +80,7 @@
}
// Decide what to log on approved requests.
- if ($settings['verbose'] || empty($package['user_agent'])) {
+ if (($settings['verbose'] && $settings['logging']) || empty($package['user_agent'])) {
bb2_db_query(bb2_insert($settings, $package, "00000000"));
}
}
the settings array now contains the key 'logging' which prevents any logging unless it's set to true.
I guess the latest BB2 is working but you wont see any evidence of it as nothing will be logged.
#5
While I'm at it, here a patch to fix this.
#6
Thanks. found answer. Install of folders is confusing. See Improved Readme issue.
b
#7
I manually applied the patch for v6.x-1.0-rc2 and it fixes the issue as well.