There are several newer versions available for download at http://www.bad-behavior.ioerror.us/download/

Is it safe to use them or should we stick with bad-behavior-2.0.13.zip mentioned in the installation instructions?

CommentFileSizeAuthor
#5 logging.patch656 bytesmoggy

Comments

Carlos Miranda Levy’s picture

The answer is, it is not.
The module does not work with the latest .zip file available for download at http://www.bad-behavior.ioerror.us/download/
It works though with the version listed in the module's instructions.

pzskc383’s picture

I'd argue with this.
Look at diff between 2.0.13 and 2.0.23: http://dpaste.com/hold/80665/
It contains only fixes and no schema changes.
Only file deleted was admin.inc.php and it is not included (at least in drupal 5.x branch).

At least it works fine for me.

MrGeek’s picture

i'm using 2.0.23 with no problems..

*Edit 11/21/08: no, i wasnt using 2.0.23 like i thought.. and when i upgraded to 2.0.25 logging stopped - but applying the patch posted below fixed it right up..

moggy’s picture

there is a change there that breaks the logging.

diff -ru 2_13/bad-behavior/core.inc.php 2_23/bad-behavior/core.inc.php
--- 2_13/bad-behavior/core.inc.php	2008-09-26 13:52:11.000000000 +0300
+++ 2_23/bad-behavior/core.inc.php	2008-09-26 13:52:53.000000000 +0300
@@ -80,7 +80,7 @@
 	}
 
 	// Decide what to log on approved requests.
-	if ($settings['verbose'] || empty($package['user_agent'])) {
+	if (($settings['verbose'] && $settings['logging']) || empty($package['user_agent'])) {
 		bb2_db_query(bb2_insert($settings, $package, "00000000"));
 	}
 }

the settings array now contains the key 'logging' which prevents any logging unless it's set to true.

I guess the latest BB2 is working but you wont see any evidence of it as nothing will be logged.

moggy’s picture

StatusFileSize
new656 bytes

While I'm at it, here a patch to fix this.

Mercury500’s picture

Thanks. found answer. Install of folders is confusing. See Improved Readme issue.

b

Carlos Miranda Levy’s picture

I manually applied the patch for v6.x-1.0-rc2 and it fixes the issue as well.

dave reid’s picture

Status: Active » Closed (duplicate)