comma separated lists of tags not created

daspit - September 2, 2008 - 09:14
Project:Integrated Metatags
Version:6.x-1.0-beta2
Component:User interface
Category:feature request
Priority:normal
Assigned:fractile81
Status:closed
Description

comma separated lists of tags not created - it is create some lines with the same name, but different context:

<meta name="keywords" value="first" />
<meta name="keywords" value="ev" />
<meta name="keywords" value="vehicles" />

But it is need to be comma separated:

<meta name="keywords" value="first, ev, vehicles" />

I find this string near at line 127 in int_meta.module:

foreach ($tag->values as $value) {set_html_head('<meta name="' . check_plain($name) . '" value="' . check_plain($value) . '" />');}

but it is need to be something like this:

foreach ($tag->values as $value) {
   $vals = "$vals, $value";
}
drupal_set_html_head('<meta name="' . check_plain($name) . '" content="' . check_plain($vals) . '" />');

NOTE: for META tags elements "value" is not good - element "content" is using for META tag

#1

daspit - September 2, 2008 - 09:22
Assigned to:daspit» Anonymous

#2

daspit - September 4, 2008 - 06:43
Version:6.x-1.0-beta» 6.x-1.0-beta2

Thank to author for fast update. "content" element looks much better then "value".
But comma separated lists is not created with new version of int_meta.

#3

fractile81 - September 4, 2008 - 14:23

Do you have the "Combine" checkbox selected for the field you want to have as a comma separated list? Also, to combine different fields (e.g. you want to combine a node.type and term.*.name fields together), the fields have to have the same name AND the "Combine" checkbox selected.

If it's still not working quite right, can you take a picture of your Integrated Metatags configuration page and attach it here? I believe this is just a configuration problem, but am willing to investigate it. Or, just explain your configuration and I'll see if I can reproduce it. Before the BETA2 came out, I had tested this and I had it working on my data.

#4

daspit - September 4, 2008 - 18:14
Status:active» fixed

Thank you, now all work fine.
It was bug of my theme: not all columns are shown (very long width for "name" input field - I attach the screenshot to comment).
Can you change the position of "combine" and "delete" columns to the left of "name" field?

AttachmentSize
1.jpg 41.19 KB

#5

fractile81 - September 12, 2008 - 15:44
Component:Code» User interface
Category:bug report» feature request
Status:fixed» active

Updated this to be a feature request for later.

#6

c4gamerz - September 12, 2008 - 15:50
Component:User interface» Code
Category:feature request» bug report
Status:active» fixed

i am still getting the same error?? i dont understand how to fix it here are the screenshots of my settings

AttachmentSize
Edit vocabulary.png 12.49 KB
Page.png 10.48 KB

#7

fractile81 - September 12, 2008 - 16:37
Component:Code» User interface
Category:bug report» feature request
Assigned to:Anonymous» fractile81

You have a fixed-width theme. There's a "Combine" checkbox to the right of the "Name" field, which your theme is cutting off. To fix this, you can either change your admin theme to be a non-fixed-width theme to see the checkbox, or update the database directly. The SQL would look something like:

UPDATE int_meta_fields SET combine = 1 WHERE name = 'keywords'

My plan is to move the checkbox to the left of the name field to help people with fixed-width themes.

#8

c4gamerz - September 12, 2008 - 17:41

ohh i got it now Thanks ;)

#9

fractile81 - September 12, 2008 - 21:48
Status:fixed» active

Updated the status since this is now a Feature Request.

#10

fractile81 - October 14, 2008 - 05:34
Status:active» fixed

I've rearranged the checkboxes now, so let me know if they helped out!

#11

Anonymous (not verified) - October 28, 2008 - 07:22
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.