Tabledrag doesn't hide columns when fieldset is collapsed

Darren Oh - September 2, 2008 - 20:01
Project:Drupal
Version:7.x-dev
Component:javascript
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs review
Description

Tested in Firefox 3. Elements in a collapsed fieldset inherit the display: none setting, and tabledrag.js skips elements with display set to none. Skipping does not seem to be necessary.

AttachmentSizeStatusTest resultOperations
tabledrag.js_DRUPAL-6.patch744 bytesIdleFailed: Failed to apply patch.View details | Re-test

#1

System Message - September 2, 2008 - 20:15
Title:Tabledrag doesn't hide columns when fieldset is collapsed» Tabledrag doesn't hide columns when fieldset is collapsed

Patch failed to apply. More information can be found at http://testing.drupal.org/node/14016. If you need help with creating patches please look at http://drupal.org/patch/create

#2

Darren Oh - September 2, 2008 - 20:32
Title:Tabledrag doesn't hide columns when fieldset is collapsed» Tabledrag doesn't hide columns when fieldset is collapsed

Bot needs to learn not to run check_plain() on issue titles.

AttachmentSizeStatusTest resultOperations
tabledrag.js-303189-2_DRUPAL-6.patch759 bytesIdleFailed: 11691 passes, 0 fails, 1 exceptionView details | Re-test

#3

bdragon - October 24, 2008 - 17:45

oh, so THAT's why I'm having problems trying to add tabledrag compatibility to location.

Subscribing.

#4

bdragon - October 24, 2008 - 17:53

The header wasn't hiding either.

AttachmentSizeStatusTest resultOperations
tabledrag.js-303189-4_DRUPAL-6.patch952 bytesIdleFailed: Failed to apply patch.View details | Re-test

#5

sradomski - March 17, 2009 - 07:08

I ran into this with a collapsed fieldset containing a draggable table. Manually applying the patch solves the problem for me at least in Safari4beta and Opera9.6.

#6

droople - May 4, 2009 - 13:26

Any updates on this? WOuld really need this for Location module

#7

Darren Oh - May 26, 2009 - 05:26
Status:needs review» reviewed & tested by the community

This is ready.

#8

Gábor Hojtsy - May 26, 2009 - 08:20
Version:6.x-dev» 7.x-dev
Status:reviewed & tested by the community» needs review

New stuff and bugfixes go first to Drupal 7 to avoid regressions popping up. Needs review on D7.

#9

System Message - May 26, 2009 - 08:30
Status:needs review» needs work

The last submitted patch failed testing.

#10

Darren Oh - May 26, 2009 - 14:40
Status:needs work» needs review

Patch for Drupal 7.

AttachmentSizeStatusTest resultOperations
tabledrag.js-303189-10.patch964 bytesIdleFailed: Failed to apply patch.View details | Re-test

#11

System Message - June 11, 2009 - 10:46
Status:needs review» needs work

The last submitted patch failed testing.

#12

Darren Oh - June 22, 2009 - 18:51
Status:needs work» needs review
AttachmentSizeStatusTest resultOperations
tabledrag.js-303189-12.patch1.37 KBIdleFailed: Failed to install HEAD.View details | Re-test

#13

System Message - June 24, 2009 - 01:10
Status:needs review» needs work

The last submitted patch failed testing.

#14

Darren Oh - July 6, 2009 - 20:26
AttachmentSizeStatusTest resultOperations
tabledrag.js-303189-14.patch1.37 KBIdleFailed: 12883 passes, 9 fails, 0 exceptionsView details | Re-test

#15

Darren Oh - July 6, 2009 - 20:29
Status:needs work» needs review

#16

System Message - September 9, 2009 - 12:50
Status:needs review» needs work

The last submitted patch failed testing.

#17

q0rban - October 7, 2009 - 12:25

#18

q0rban - October 7, 2009 - 12:28

This definitely needs work, as there's lots of cruft in tabledrag from getting it to work in older browsers. Please see this comment.

#19

q0rban - October 7, 2009 - 13:42
Status:needs work» needs review
AttachmentSizeStatusTest resultOperations
tabledrag.js_303189_19.diff1.65 KBIdlePassed: 14689 passes, 0 fails, 0 exceptionsView details | Re-test

#20

udig - October 8, 2009 - 06:44

#425148: Form elements within a field group are not visible in Internet Explorer was marked as duplicate for this issue. Is it?
The symptoms mentioned here seems to be different then those mentioned there.

In addition can the above patch be applied for D6 as well or only D7?

thanks.

#21

Darren Oh - October 8, 2009 - 11:23

Use the patch in #4 for Drupal 6.

#22

q0rban - November 8, 2009 - 22:02

Keeping up to date with HEAD. Still needs review!

AttachmentSizeStatusTest resultOperations
tabledrag-303189-22.patch1.65 KBIdlePassed: 14710 passes, 0 fails, 0 exceptionsView details | Re-test
 
 

Drupal is a registered trademark of Dries Buytaert.