Problem:
The confirmation page genaretes these warnings 

* warning: Missing argument 2 for node_multiple_delete_confirm() in C:\www\drupal\modules\node\node.admin.inc on line 604.
* warning: Invalid argument supplied for foreach() in C:\www\drupal\modules\node\node.admin.inc on line 608.

Cause:
node_multiple_delete_confirm() in D6 requires argument

Solution:
simple patch attached

CommentFileSizeAuthor
domain_content.admin_.inc_.patch786 bytesariflukito

Comments

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Active » Needs review

Thanks. Will test later. Is this, by chance, related to #301244: Content on admin/domain/content/* and admin/domain/content is visible to anonymous users?

ariflukito’s picture

ariflukito commented

No I don't think it's related
but I can confirm the bug

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

I think this is a batch permissions issue. I would be that only users who can 'administer nodes' can batch delete. We should probably sanitize the action dropdown based on that.

ariflukito’s picture

ariflukito commented

I got that error even trying to delete 1 node only and I was logged in as administrator will all rights. I'm pretty sure it's not permission issue.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Ah -- looking at the actual patch, this becomes clear. Too much travel for me. Code looks good, though I wonder if the $_POST is necessary here -- bad Drupal form to grab variables from the POST. (THough I suspect this is what core does in this case.)

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs review » Fixed

Nice patch. Committed.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.