log message in email without variables

Committed to the -dev version.

Please wait for 24 hours and then download and test it. If it works I can make a stable release.

How can that be?

Your patch had this:

- '@message' => strip_tags($log_msg['message']),
+ '@message' => strip_tags(strtr($log_msg['message'], $log_msg['variables'])),

But, if 'variables' was empty or not an array, we got errors, so I change it to this:

  if (is_array($log_msg['variables'] && !empty($log_msg['variables']))) {
    $msg = strtr($log_msg['message'], $log_msg['variables']);
  }
  else {
    $msg = $log_msg['message'];
  }

Then used $msg afterwards, which should do the same ...

I committed a fix for this.

Either get it from CVS (DRUPAL-6--1 tag) or download the tarball after 24 hours have passed.

Apologies if you already noticed this, but the problem with the variables not being substituted was just a matter of a misplaced parenthesis.

this:

  if (is_array($log_msg['variables'] && !empty($log_msg['variables']))) {

should be this:

  if (is_array($log_msg['variables']) && !empty($log_msg['variables'])) {

After that change, it works fine.

Can you please create a patch as per the instructions here http://drupal.org/patch, and attach it to the issue?

Make sure it is in unidiff format, tested and against the 6.x-1.x-dev tarball.

I found the following code problem and come here to report it but it seems already here.

<?php if (is_array($log_msg['variables']) && !empty($log_msg['variables'])) { ?>

please add this into upcoming releases.

The code has been changed to if (is_array($log_msg['variables'])) { in the 6.x-1.x-dev. This covers all bases and works just fine, so marking as fixed. We'll just have to wait for a release now.

subscribing

@andrex593: It doesn't do much good to subscribe to a closed issue. Download the 6.x-1.x-dev version and you'll notice the problem is fixed.

@Dave: Thanks, I did install the -dev version, and notice that the problem is fixed.

Nevertheless, it does do me some good to subscribe to a closed bug. (1) Sometimes closed bugs get reopened again, or there's further illuminating discussion. (2) If I have to apply a fix related to a bug, it helps me to have it in my bug list, so I can find it again easily when I have questions about it again in the future.

Thanks,
Andrew.

Hi,
I read from above that this issue is fixed in the dev version

But the most recent CVS message is from December 2008 http://drupal.org/project/cvs/135107?nid=135107&nid=135107

I guess this is wrong - but without any info about what else might be in a nightly build I'm reluctant to install it.

Any chance of a stable release that includes this fix?

Thanks

@seanburlington If you'd look at the project page you'd also notice that the 6.x-1.3 release was made on 2008-Sep-25, so if a commit was made on Dec 2008 (Dec comes after Sep), it's included only in the 6.x-1.x-dev version. I'm going to ask kbaley to see if I can help co-maintain this module and push out a new release.

Resetting more issue settings...

A 6.x-1.4 release should be available shortly. Thank you to kbaley for adding me as a co-maintainer.

kbahey!

@kbahey: Ah crap. My fingers wanted to tyep ai instead of a. My apologies. :(