Too much recursion in drupalforfirebug.module on line 346

mikl - September 3, 2008 - 11:54
Project:Drupal For Firebug
Version:6.x-1.1
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

I ran into the following when enabling the Drupal for Firebug module:

Fatal error: Nesting level too deep - recursive dependency? in /home/mih/www/drupal6/sites/all/modules/contrib/drupalforfirebug/drupalforfirebug.module on line 346

I'll try to dig a bit more into it to see if I can reproduce it.

#1

mikl - September 3, 2008 - 12:01

I tried messing a bit around with it, and it happens on every page as long as the module is loaded.

#2

alanburke - September 3, 2008 - 15:55

Encountered the same problem.
Perhaps it's an conflict issue with another module.

I'm trying to pinpoint it.

Alan

#3

upupax - September 9, 2008 - 12:58

Same problem..

#4

ksenzee - September 9, 2008 - 19:16
Version:6.x-1.0» 5.x-1.1

I get it on line 332. In my case it seems to be a conflict with the actions module; so far I've only seen it at admin/build/trigger/*.

#5

ksenzee - September 9, 2008 - 19:17

Oops, didn't mean to change the version.

#6

ksenzee - September 9, 2008 - 19:18
Version:5.x-1.1» 6.x-1.0

Aargh.

#7

vmiliano - September 10, 2008 - 19:20

I get this same error, same line number, on pages that have views on them. If I comment out drupalforfirebug_views_pre_view(), the error goes away. Does drupalforfirebug_array_compare_code() recurse like crazy into the view for some reason? Can that be done without recursion?

#8

populist - September 10, 2008 - 19:23

The views 2 support is a little bit fragile at the moment and there is a good chance the data coming back from there (or the method that is collecting the data) is causing some breakage. Investigating as well.

#9

populist - September 15, 2008 - 06:22

There was a bit of refactoring to how the objects were being compared to be a little more efficient and to prevent a few recursive issues. I am not able to replicate the problem with Trigger module, but will keep investigating. Please try the latest module version and see if the errors are still there and what modules you might be enabling.

#10

mikl - September 15, 2008 - 10:23

I tried it out with the latest 6.x-dev snapshot, but that gives the same error.

The modules I have enabled on that site:

admin_menu
advanced_help
diff
jquery_ui
logintoboggan
scheduler
switchtheme
token
transliteration
cck
fieldfield
imagefield
imageapi
imagecache
schema
date_api
date
date_popup
coder
devel
nodequeue
jquery_update
views

Plus a smattering of in-house-developed, client-specific modules.

#11

populist - September 17, 2008 - 05:50
Status:active» fixed

I added some generalized recursive code to the module and I hope that resolves this issue! Will issue a release soon and give that a whirl. Resolved the test problem I was able to recreate with recursive items in panels.

#12

vidda - September 29, 2008 - 06:56
Version:6.x-1.0» 6.x-1.1
Status:fixed» active

I just enabled stable version 6 1.1 and Fatal error: Nesting level too deep - recursive dependency again. Seems not corrected. Or shoud I use latest development snapshot?
I have many mdules installed, maybe that is the problem?

#13

Wim Leers - October 3, 2008 - 00:57

Subscribing.

#14

arcane - November 30, 2008 - 21:09

Subscribing

#15

comargo - February 7, 2009 - 09:10
Status:active» needs review

for version = "6.x-1.0":
I've got same bug.
Fast google gives me with first link:
http://www.bigroom.co.uk/blog/php-nesting-level-too-deep-recursive-depen...

Realy I havn't read it all and just tried the solution at the end of the article:
---
echo ( $a == $c ); // Fatal error:
Nesting level too deep - recursive dependency?
---[skipped]---
Once you know the problem, the solution is easy - use strict comparison.
echo ( $a === $c ); // false (and no error)
---

It helped me.

Patch file attached. (there are two places with same bug on the same function.)

AttachmentSize
drupalforfirebug.module.recursive_dependency_fix.patch 929 bytes

#16

kndr - February 7, 2009 - 09:56

#15 works for me. Thanks!

#17

comargo - February 7, 2009 - 17:20

kndr: Nice to hear it.

Small update (noticed that drupal recomends me to update the module to 1.1)
Same problem occurs. Attached patch for version 1.1 (patch for 1.0 was rejected on 1.1 :( )

AttachmentSize
drupalforfirebug.module.recursive_dependency_fix.patch 880 bytes

#18

Matt V. - February 18, 2009 - 04:07

The patch fixed the issue for me under 6.x-1.1.

#19

populist - March 1, 2009 - 06:11
Status:needs review» fixed

thank you for this patch. tested and committed. will roll out a new release soon.

#20

System Message - March 15, 2009 - 06:20
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.