Download & Extend
Legal » Issues

incorrect compare for legal_user update with legal_version_check return value

Posted by AndCycle on September 3, 2008 at 2:37pm
Project:Legal
Version:5.x-1.9
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

       // if already accepted skip data entry
        $accepted = legal_version_check($account->uid, $conditions['tc_id']);
       
        if ($accepted == TRUE) break;
       
        legal_save_accept($account->uid, $conditions['tc_id']);
        break;

will,
legal_version_check return $log_messages as false, but this is just text and will compare as true,
do strong compare with === , please
Login or register to post comments

Comments

#1

Posted by Robert Castelo on March 27, 2011 at 1:15am
Status:active» fixed

Fixed in Drupal 6 version.

#2

Posted by System Message on April 10, 2011 at 1:21am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here