Closed (fixed)
Project:
Advanced Forum
Version:
6.x-1.x-dev
Component:
Styles
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
3 Sep 2008 at 16:14 UTC
Updated:
7 May 2009 at 03:06 UTC
Jump to comment: Most recent file
This is steph's baby... Placeholder issue.
Michelle
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | flatgrey-version2.zip | 60.82 KB | jeremycaldwell |
| #6 | flatgrey.zip | 62.15 KB | jeremycaldwell |
Comments
Comment #1
stephthegeek commentedMy spare minutes of time seem to have gone even deeper into hiding lately, but Jeremy (http://drupal.org/user/72964) is awesomely gonna finish this style up this week.
Comment #2
michelleYay! Thanks, Jeremy. :)
Michelle
Comment #3
michelleAny news on this?
Michelle
Comment #4
stephthegeek commentedJeremy & wife had a baby girl early this week so needless to say this got a little bumped back! As far as I know, he'll be picking it up again next week.
Comment #5
michelleOh, yeah, that definitely takes priority! Congrats, Jeremy & wife!
Michelle
Comment #6
jeremycaldwell commentedSorry for the delay, been a little busy lately :)
Here is the latest release of the Flatgrey theme for Advanced Forum. Please let me (or us) know if there are any outstanding issues with the theme and I'll get them fixed. This is my first time working with Advanced Forum and I love it, but am still not completely familiar with it yet. So hopefully I didn't miss too much here.
Comment #7
michelleActually, this is perfect timing. AF just opened up to new features yesterday. :)
I've got to catch up on some client work but will get this in ASAP.
Michelle
Comment #8
michelleOk, I took a little time to install it on my dev site. The forum / topic list pages look pretty good but the posts themselves have some layout issues. You can see it here:
http://6dev.shellmultimedia.com/node/1460
I've tried it in a couple of themes and a couple of browsers and have the same problem.
Thanks for working on this!
Michelle
Comment #9
jeremycaldwell commentedHere is version 2 of the FlatGrey theme. I reworked it quite a bit so it should look and work correctly with the latest version of Advanced Forum. Let me know if there are any outstanding changes that need to be made, thanks!
Comment #10
michelleYay, thanks! I'll give it a try soon as I can.
Michelle
Comment #11
michelleWhoops, going thru my issue queue and I realized I forgot to comment on this. The latest iteration still didn't work right for me. At this point, though, I suggest you hold off on this until alpha 14. I've been making a lot of changes that will need to be incorporated into flatgrey as well so it's chasing a moving target.
Thanks,
Michelle
Comment #12
eidolon nightAt http://6dev.shellmultimedia.com/node/1460 the bottom of the first post seems to overlap with the top of the second post. Any idea what's up?
Comment #13
dbirider commented(duplicate post)
Comment #14
dbirider commentedThe reason for the overlap is because #comments is set to 'margin:-1.5em -25px 0;'. It looks like it should be changed to 'margin: 0 -25px;' to look normal.
Comment #15
michelle@Eidolon Night / dbrider - That negative margin is Garland, not in AF, so there's nothing to fix. This has nothing to do with the flatgrey style, which isn't even in use on that site at the moment.
Michelle
Comment #16
eidolon nightAh, thank you.
Comment #17
CompShack commentedYes, I was having the same problem as well. Just open the advanced_forum.css file for the style you are using and add at the very end the below CSS.
.top-post {
margin-bottom:23px;
}
Save and refresh your page. Problem solved ;)
Cheers!
NOTE: This is really not related to flatgray style (as i have not tested it) BUT rather I've noticed it in all other styles!
Comment #18
Shyin commentedI am using a modified version of the Framework Theme. I do not have this issue. I am also using AF version 6.x-1.0-alpha15, with a modified version of the Blue Lagoon Style. I dont believe this is an AF issue, but a Garland, or modified version of garland issue.
My site: Shyins
Comment #19
michelle@Shyin - You are correct, it is a Garland issue. It's unfortunate that it makes AF look wrong but fixing Garland would be out of scope for AF and break other themes.
Michelle
Comment #20
CompShack commentedHow is my fix affecting Non Garland themes? I don't think it breaks any thing -maybe a little more space after the 1st post :)
.top-post {
margin-bottom:23px;
}
Comment #21
michelleThat's exactly it. It adds extra space under the top post to fix one theme and then all other themes have uneven spacing. It's not AF's job to fix Garland.
Now, please, this has _nothing_ to do with the flatgrey style. Let's stop polluting this issue with off topic talk.
Michelle
Comment #22
michelleI'm going to hold this over for 2.x. Trying to get 1.0 out before the end of the year and it doesn't look like this style will make it in.
Michelle
Comment #23
michelleClosing this for now. Might be re-opened at some point.
Michelle