Unassigned terms don't show up... Can we enable an option to display them?
livingegg - September 3, 2008 - 22:03
| Project: | Suggested Terms |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
Hi there. This module rocks, thanks for building and maintaining it. It took me a bit of digging around to figure out why most of my terms were not showing up though... it seems that terms which have not yet been assigned to any nodes do not show up. Did you do this on purpose? If so, it would be nice to have it explicitly stated somewhere, because I have seen several issues submitted for this module about terms not showing up that may have been due to this very reason, but its not pointed out on the project page, or anywhere I could find.
Better yet, how difficult would it be to enable an option that allows me to show the terms that havn't been used yet? Maybe a checkbox in the admin settings for the module? Cheers.
#1
I had the same problem. When creating a new site, I define a number of 'suggested' terms for each freetagging vocabulary. I want them to be displayed as suggestions to help the user, while the user of course has the option to create their own terms.
With this module, as it currently exists, my existing suggested terms are _not_ displayed (because no nodes use them yet). So the only thing that the user sees is funny bungee jumping. Not what I had in mind when I created a list of suggested terms.
Attached is my solution (for version 6.x). I've just changed the SQL to LEFT JOIN rather than INNER JOIN. I don't know if that's the right solution or not, but it does make my initial seeding terms show up as links and work as expected.
#2
New features are not being accepted against the 5.x branch, only the 6.x branch. Can you confirm this still works against 6.x-dev?
#3
Hi Crell,
I have tested that patch alongside my own (http://drupal.org/node/433974) for adding a scroll bar to long term lists, and it works correctly in Drupal 6.
IMHO, what RSTaylor's patch does is the correct way to do it. One creates the term list based on logical criteria, and one then wants to write articles using it. Unless unused terms show up, the prior work is pointless.
Thanks,
Ron.
#4
I have been doing some more work on this issue and I have what I think should please everyone: a configuration option to let the user select whether to see all terms or only previously assigned terms. As I have been working on my other issue http://drupal.org/node/433974 at the same time, and as the two patches concern the same bits of code, the two patch files (but not the two sets of modifications!) are incompatible, so I include three variants of this patch file: one that applies only this patch (I call it the whichterms patch) to the standard distribution, one that applies this patch to a directory that has already been given my other (scrollbar) patch, and one that applies them both together in a single patch to the standard distribution. All are made against suggestedterms-6.x-1.2.tar.gz. With both patches applied, the module is extremely flexible.
Cheers, Ron
#5
#6
Thanks for submitting the patch! Here's an update to whichterms.patch. It was overall very good. I just added some syntax changes to your patch and to the module in general.
#7
Here is a patch that includes both my previous patch and the scroll bar patch
#8
Here's a newly updated patch to go with the recently updated patch.
#9
Let's keep these issues separate. The all-terms patch can continue here, but the scrollbar patch really needs to stay separate in #433974: Add a scrolling box for longer lists of suggestions
#10
Here is the patch for showing all of the terms.
#11
Committed a slightly modified version of #10. Thanks all!
#12
Automatically closed -- issue fixed for 2 weeks with no activity.