This patches adds a setting to enable YouTube high quality videos. See http://www.mydigitallife.info/2008/06/12/how-to-embed-high-quality-and-h... for information about how to embed higher quality YouTube videos.

CommentFileSizeAuthor
#5 high_quality.patch1.79 KBvm
#2 youtube.patch1.72 KBjrefano
youtube.patch2.88 KBbenshell

Comments

jrefano’s picture

jrefano commented
Status: Needs review » Needs work

Just tried to apply this patch to 5.x-1.x-dev and 5.x-1.3, fails both hunks on both versions.

jrefano’s picture

jrefano commented
Status: Needs work » Needs review
StatusFileSize
new youtube.patch1.72 KB

Based on the date, I'm guessing it was just an old patch, so here's one for the latest 5.x-1.x-dev that patches ok.

vm’s picture

vm commented

great patch. Was wondering how to do this myself. I've had to apply it by hand for 6.x. If someone can point me to a document to show me how to do a diff and create a patch, I will supply for the D6 version.

vm’s picture

vm commented

edit: found the creating patches document = http://drupal.org/patch/create

vm’s picture

vm commented
Version: 5.x-1.x-dev » 6.x-1.x-dev
StatusFileSize
new high_quality.patch1.79 KB

attached is the patch for 6.x-1.x-dev

My patch (broke my virginity) for 6.x is different then the one supplied by jrefano in that it follows the name spacing already used in youtube.inc. Moves the checkbox above the youtube api collapsed menu and rewords the description some.

vm’s picture

vm commented
Title: Add YouTube High Quality option » Patch allowing for high quality content from youtube

If we can get some testers for this, we can RTBC it and get it in -dev

May be nice if we could squeeze in a settings area specific to high quality content.

as it stands now, if the high quality content is set, and the video size is set to a high quality setting, then when a video doesn't have that high quality version the low quality version is used and displayed at same height and width. which can be a bit ugly.

aaron’s picture

aaron commented

nice. great work folks, just in time for the new release. i plan to do more work on the module tomorrow, so we can easily roll this into the second beta.

vm’s picture

vm commented

I was hoping to see this in the the new -dev rolled tonight.

Has anyone other than myself tested my patch for D6 ?

aaron’s picture

aaron commented
Status: Needs review » Fixed

fixed it up a bit (bad quotes, moved to player options in settings), rolled against latest versions, tested, committed to d6 and backported to 5.

thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

vm’s picture

vm commented
Category: feature » bug
Status: Closed (fixed) » Active

This setting (for youtube Highg Quality) may be broken in the latest 6.x-1.x-dev from July 17th.

The video no longer starts in High Qualiy when there is a High Quality version available.

robloach’s picture

robloach
he/him
commented
Status: Active » Fixed

YouTube changed their API to "&hd=1". Yay committed! Thanks a lot.

vm’s picture

vm commented
Status: Fixed » Active

Still not working on my end, I also found http://drupal.org/node/457228 which mentions the &hd=1 as well

Updated to 1.3.x and still no go.

Digging now

alex ua’s picture

alex ua commented
Status: Active » Closed (fixed)

This is fixed in the Media: YouTube module- please upgrade to that module to use it.