display problem "devel_themer_ie_fix.css"

kbahey - September 4, 2008 - 05:07
Project:Devel
Version:6.x-1.8
Component:devel_themer
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Issue tags:devel themer info is not bottom in IE
Description

The capitalization is not very consistent and does not follow Drupal's standard.

Need to standardize it.

#1

kbahey - October 20, 2008 - 19:57
Project:Performance Logging and Monitoring» Devel
Version:5.x-1.x-dev» 6.x-1.x-dev
Component:User interface» performance

Moving to devel queue, since the module is now part of that.

#2

moshe weitzman - April 10, 2009 - 14:59

I welcome patches for coding standards.

#3

jcmarco - April 21, 2009 - 11:29
Status:active» needs review

Using Coder

AttachmentSizeStatusTest resultOperations
performance_module_coder.patch7.48 KBIgnoredNoneNone
performance_install_coder.patch4.36 KBIgnoredNoneNone

#4

moshe weitzman - July 30, 2009 - 19:36

@kbahey - look OK to you?

#5

kbahey - August 7, 2009 - 15:50
Version:6.x-1.x-dev» 7.x-1.x-dev
Status:needs review» patch (to be ported)

jcmarco, thank you. I committed it for 6.x.

Can you be so kind as to download 7.x-1.x-dev tomorrow (because I just committed a change that will be packaged in about 9 hours from now) and do the same for it and submit a patch?

#6

jcmarco - August 8, 2009 - 23:31

Checked with last coder 7.x-dev

performance.install:
practically the same with just a correction in @file

performance.module:
added a recommendation for new drupal_module_exist.
I haven't changed the time() recommendation as I guess that it is necessary accuracy with timings.

AttachmentSizeStatusTest resultOperations
performance_install.patch6.88 KBIgnoredNoneNone
performance_module.patch6.54 KBIgnoredNoneNone

#7

jcmarco - August 8, 2009 - 23:32
Status:patch (to be ported)» needs review

#8

kbahey - August 9, 2009 - 00:37
Status:needs review» fixed

thanks you!

#9

System Message - August 23, 2009 - 00:40
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

#10

mycat - November 9, 2009 - 12:05
Title:Capitalization needs to follow Drupal's standard» display problem "devel_themer_ie_fix.css"
Version:7.x-1.x-dev» 6.x-1.8
Component:performance» devel_themer
Status:closed» active

first, sorry for my english.

in the devel-module, in devel_themer_ie_fix.css is an little error.

original Code (:

#themer-toggle {
  position: absolute !important;
  top: 0 !important;
  bottom: auto !important;
}

This text has also effect: "Themer Info" is not formatted as "bottom" ...
And: with absolute position the "Themer Info" is scrolling with the Layout.

must be:

#themer-toggle {
  position: fixed !important;
  top: auto !important;
  bottom: 0 !important;
}

fixed: "Themer Info" is too in IE always bottom!
With position fixed the "Themer Info" do not scroll with the Layout!

Thanks an greetings

Fredi

P.S. i hope, this is the right place for this message.

#11

jcmarco - November 9, 2009 - 19:03

Probably, the best would be to open a new issue

#12

moshe weitzman - December 18, 2009 - 02:05
Status:active» closed
 
 

Drupal is a registered trademark of Dries Buytaert.