Download & Extend
Devel » Issues

display problem "devel_themer_ie_fix.css"

Posted by kbahey on September 4, 2008 at 5:07am
Project:Devel
Version:6.x-1.8
Component:devel_themer
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:devel themer info is not bottom in IE

Issue Summary

The capitalization is not very consistent and does not follow Drupal's standard.

Need to standardize it.

Login or register to post comments

Comments

#1

Posted by kbahey on October 20, 2008 at 7:57pm
Project:Performance Logging and Monitoring» Devel
Version:5.x-1.x-dev» 6.x-1.x-dev
Component:User interface» performance

Moving to devel queue, since the module is now part of that.

#2

Posted by moshe weitzman on April 10, 2009 at 2:59pm

I welcome patches for coding standards.

#3

Posted by jcmarco on April 21, 2009 at 11:29am
Status:active» needs review

Using Coder

AttachmentSizeStatusTest resultOperations
performance_module_coder.patch7.48 KBIgnored: Check issue status.NoneNone
performance_install_coder.patch4.36 KBIgnored: Check issue status.NoneNone

#4

Posted by moshe weitzman on July 30, 2009 at 7:36pm

@kbahey - look OK to you?

#5

Posted by kbahey on August 7, 2009 at 3:50pm
Version:6.x-1.x-dev» 7.x-1.x-dev
Status:needs review» patch (to be ported)

jcmarco, thank you. I committed it for 6.x.

Can you be so kind as to download 7.x-1.x-dev tomorrow (because I just committed a change that will be packaged in about 9 hours from now) and do the same for it and submit a patch?

#6

Posted by jcmarco on August 8, 2009 at 11:31pm

Checked with last coder 7.x-dev

performance.install:
practically the same with just a correction in @file

performance.module:
added a recommendation for new drupal_module_exist.
I haven't changed the time() recommendation as I guess that it is necessary accuracy with timings.

AttachmentSizeStatusTest resultOperations
performance_install.patch6.88 KBIgnored: Check issue status.NoneNone
performance_module.patch6.54 KBIgnored: Check issue status.NoneNone

#7

Posted by jcmarco on August 8, 2009 at 11:32pm
Status:patch (to be ported)» needs review

#8

Posted by kbahey on August 9, 2009 at 12:37am
Status:needs review» fixed

thanks you!

#9

Posted by System Message on August 23, 2009 at 12:40am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#10

Posted by mycat on November 9, 2009 at 12:05pm
Title:Capitalization needs to follow Drupal's standard» display problem "devel_themer_ie_fix.css"
Version:7.x-1.x-dev» 6.x-1.8
Component:performance» devel_themer
Status:closed (fixed)» active

first, sorry for my english.

in the devel-module, in devel_themer_ie_fix.css is an little error.

original Code (:

#themer-toggle {
  position: absolute !important;
  top: 0 !important;
  bottom: auto !important;
}

This text has also effect: "Themer Info" is not formatted as "bottom" ...
And: with absolute position the "Themer Info" is scrolling with the Layout.

must be:

#themer-toggle {
  position: fixed !important;
  top: auto !important;
  bottom: 0 !important;
}

fixed: "Themer Info" is too in IE always bottom!
With position fixed the "Themer Info" do not scroll with the Layout!

Thanks an greetings

Fredi

P.S. i hope, this is the right place for this message.

#11

Posted by jcmarco on November 9, 2009 at 7:03pm

Probably, the best would be to open a new issue

#12

Posted by moshe weitzman on December 18, 2009 at 2:05am
Status:active» closed (fixed)
nobody click here