Hi, and thanks for this great addition to the drupal community!

I have just installed for the first time the module, I think we will be using it on this proyect. Works great so far, thanks for the tpl and css files, i was able to just copy and paste the file into my theme directory, easily allowing me to add another div around the prev next icons so that i could position them according to the theme.

That said, the feature request is that it'd be nice if js isn't enabled, that the view would drop to another style, this ideally you'd be able to choose while configuring the style in the views page. I don't even know if this is possible with views at the moment, but it would surely be great!

Not sure how else it could be done to degrade easily if js inst enabled on the browser. Currently, you just get one view row if js is disabled, so nothing is broken, but the rest of the rows are just not available. Perhaps enabling the pager for the view if js isnt enabled?

Again, just brainstorming here how it could be done. I think the module has great potential, and is a great addition to views.

Greetings from Barcelona!

Comments

mfer’s picture

mfer commented

I'm not sure you can switch the style within a plugin. I'll have to take a look into this. Views controls the style and if there is no easy way with views it would take a lot of work to fall back to a different style.

I'll look into a pager. If someone wants to write up a patch for that I'd take a look at it.

manuel garcia’s picture

manuel garcia commented

Yes, I was just thinking that switching to a different style is probably not an option. I'm not a developer per say, however, I am learning, it'll be a good excercise to see how this could be done (using foward and back buttons and anchors?), so I will take a look when i get some spare time.

Will let you know if I manage anything :) -thanks for the reply!

mfer’s picture

mfer commented
Status: Active » Fixed

While I can't set it to use a different style plugin if JavaScript isn't enabled I did provide some more control in displaying the items.

In the .tpl.php file for the view we used to call a function that controlled the display of the first item and then hid the others. I made that function the theme function theme_views_rotator_display_item. It can now be overridden. If JavaScript is off you can override this function and set it to display every item, every other item, or some other logic of your choosing.

The JavaScript will still hide all the items but the first if it's loaded.

manuel garcia’s picture

manuel garcia commented

Outstanding mfer! -many thanks

I have upgraded our site, and it is working perfectly (had to update the tpl to reflect the changes in it, of course).

I have taken a look at the new function:



/**
 * Only returns true the first time it's called for an id
 *
 * @param $id
 *  A uniqe view id.
 *
 * @return bool
 *  TRUE for the first time called for a given $id
 *  FALSE for each time after that
 */
function theme_views_rotator_display_item($id) {
  static $display = array();

  if (!isset($display[$id])) $display[$id] = FALSE;

  $output = $display[$id];

  if ($display[$id] == FALSE) $display[$id] = TRUE;

  return $output;
}

However, due to my tourist-php-skills, I can't seem to figure out how to do what you mention above, could you give an example use? (for example, display 5 items from the view if js is turned off)

My problem of course is that I don't know what this function actually does/works...

Anyhow, this is a very nice push forward, and so far I didn't see any bugs - :D

mfer’s picture

mfer commented

I can see why this is confusing. I'll add making this more clear and easier to use to the next alpha release.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.