Currently, nodequeue_node_tab_access() loads all potential (sub)queues for a node and then eliminates the ones that the current user can't access with nodequeue_api_subqueue_access. The 'manipulate queues' permission exists as a performance saver to prevent these queries from being run when a user does not have the 'manipulate queues' permission. For the purposes of access restriction, calling user_access first before nodequeue_api_subqueue _access would be redundant, but doing so makes loading the nodequeue node tab significantly more efficient when a user does not have the 'manipulate queues' permission.

Comments

ezra-g’s picture

ezra-g commented
Priority: Normal » Critical

Marking as critical, since this performance improvement was part of 5.x and is necessary for a 6.x release. I should be able to take care of this this soon.

ezra-g’s picture

ezra-g commented
Status: Active » Fixed

Sooner than expected. Fixed.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.