Hey,

Just noticed potentially another issue in the comment module.

In the comment_new_page_count, it was blowing up on the query:

(SELECT thread FROM {comments} WHERE nid = %d AND status = 0 ORDER BY timestamp DESC LIMIT %d) trds ORDER BY thread DESC LIMIT 1

Attached is a patch to address this.

CommentFileSizeAuthor
#3 comment.pg_new_page_count.patch1.7 KBsocki
comment.new_page_count.patch1.67 KBsocki

Comments

Patch failed to apply. More information can be found at http://testing.drupal.org/node/14054. If you need help with creating patches please look at http://drupal.org/patch/create

damien tournoud’s picture

damien tournoud commented
Version: 6.4 » 7.x-dev
Component: postgresql database » comment.module
Status: Needs review » Needs work

Bumped to D7, as the code is the same there. The change looks significant, we will need a test for this.

socki’s picture

socki commented
StatusFileSize
new comment.pg_new_page_count.patch1.7 KB

Actually, here is a proper patch file which should pass the testbed bot as i had created the patch from inside the wrong directory.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Closed (duplicate)

I'm pretty sure this has been adressed in the mean time as there were a lot of changes to that function.

(Sorry for pinging the participants, I'm trying to clean up a few old
issues)