Closed (won't fix)
Project:
Notifications
Version:
6.x-4.x-dev
Component:
User interface
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
4 Sep 2008 at 16:34 UTC
Updated:
23 Dec 2011 at 04:02 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jwhatcott commented+1 on this request. I've seen a few other similar requests in the issue queue as well.
Comment #2
jose reyero commentedYes, I think this is an interesting feature, and could be easily built as a small plug-in.
However, I also think we could generalize the feature and try to reach a bit further. Let's try to spec it out a little bit before.
What about subscribing to 'event types' instead of objects themselves? I.e. this would be 'Subscribe to 'node posts', 'node updates', 'node comments', 'user register', etc, etc...
If someone has some more time than I do and wants to go a little further, what about subscribing to Drupal 6 core triggers and actions?
About the UI part, I think we don't really need too much, just a tab on the user account for thinks kind of 'global/event' subscriptions...
See, not the same but somehow related,
http://drupal.org/node/255402
http://drupal.org/node/260100
So, definitely interested, time for feedback... and nice patches ;-)
Comment #3
Gabriel R. commentedIt would make sense to have a dedicated plugin to enable all users to subscribe to a "What's New" automatic email.
Actually, what I am looking for is exactly the functionality of the Notify mudule, but integrate with the Notification framework. I tried using both together, but this results in two different tabs, which is very confusing to users.
Comment #4
jose reyero commentedMerging two related feature requests in this one:
- Automatically subscribe to news letter, #309389: Automatically subscribe new users to a newsletter issue from the simplenews module
- Create bulk subscriptions (Subscribe all users to...), #296349: Subscribe all users to a content type
And upgrading to 'task'. So this is definitely something to do, better if we support all these features at once.
Comment #5
esadot commentedI was fooling around, and came up with a small module which allows the admin to subscribe new users to content type (introducing new checkbox at admin/messaging/notifications/content). Needs more work to become robust and comprehensive, but hey, it's a start.
Comment #6
drein commentedOh great!
It is for drupal5 so I can test it.
Then I'll tell you if it works.
Comment #7
drein commentedYes, works very well!
I created a new user, and he is subscribed to all the type of contents I selected before using admin.
Well done!
Now I'm going to search if exists something that can update all users profile... I was using the notify module, and if I find a manner to subscribe all users to selected type of contents, I can uninstall it and use only notifications.
Still thank you.
Comment #8
MedicSean37 commentedI couldn't get the module in a Drupal 6 flavor could I? Would it be as simple as changing the info file?
Comment #9
jose reyero commentedThe module looks good and it will do the work. However we are looking here for some more generic solution. In the meanwhile people can customize and use that module...
Comment #10
esadot commentedAm not presuming on competing with the comprehensive / generic solution. Simply my contribution back to the community.
Comment #11
sagannotcarl commentedI want to add a use case in here which is more about the generalized 'subscribe to events' part of this thread suggested in #2.
What I'm looking for is to have users receive a notification when new content is created, but not receive notifications of comments by default. Then I want autosubscribe to do it's thing to have users receive notifications of comments on any content they authored or have previously commented on.
Another interface option could be something like what's already going on in the Content Subscriptions tab, but for each content type there could be three radio buttons (instead of the "Allowed..." checkbox currently):
* Allow users to subscribe (opt-in) [this is the same as the current check box]
* Subscribe all new users automatically (opt-out) [this would represent a more generalized version of the functionality of the module in #10]
* Notify (but not subscribe) all new users [this is my use case]
Right now users are either subscribed to a content type or not (Content Subscriptions), and if they either get notifications of comments or not (via the Events tab). There isn't a way (that I can see) to have autosubscribed users get notifications of comments but not other users.
I hope this is a helpful example. Let me know if I should really start a different feature request instead of putting it here.
Colin
Comment #12
MedicSean37 commentedThanks so much! This is the one and only feature that really is missing from the notifications module compared to the subscriptions.
If you ever get a chance. It would be nice to have more of a granular auto subscribe for content types. I have a local community site, and I would like for the users to be able to subscribe to articles, events, classifieds, business listings. But I really want to only have them automatically subscribed to events and classified ads.
Thanks again. This really did help.
Comment #13
esadot commentedDear Colin,
Not sure I fully understand your use-case, but i reckon I got most of it. In any event, I don't believe the core notifications module distinguish between comment vs. newly-created-posts, thus may I suggest opening a new feature request altogether against the core notifications module.
Regards,
Comment #14
esadot commentedYou're most welcome MedicSean37.
Would be happy to help in your request, that's if i can of course. Please let me echo back (or shall I say rephrase) your request, just to make sure I understand your request, and that we're on the same page.
Assuming drupal fresh installation, Page and Story are two, and only two, available content types.
You would like to:
a. Allow users to subscribe to Story and/or Page through their Notifications tab under my-account (as of today)
b. But to allow admin to set auto-subscribe only to one content type (Story or Page or both)
In a nutshell - to untie the user's subscription options and the auto-subscription?
Comment #15
MedicSean37 commentedesadot,
Yep, that's it. It would be a really great feature.
Comment #16
esadot commentedThis might do the trick. Introducing a new autosubscribe tab in the notification settings page (admin/messaging/notifications). The code is a bit clutter, and i imagine that a php savvy would have done a better work, but I believe it works.
Comment #17
sagannotcarl commentedesadot,
First of all thanks for posting your code. I've installed the d5 version and it worked great!
To clarify my point earlier, I want to be able to subscribe to a specific event for a certain content type (getting only a notification when a new Story is posted and not when a new comment is added to that post, even if new comment is allowed in the Event tab) as opposed to the current situation of subscribing to a content type period (getting a notification for every event -- creation, update, comment, etc -- that is allowed in the events tab). Right now subscribe by content type and autosubscribe aren't really working together to each do what they do best. Autosubscribe seems to be super useful for people to get comments to threads they are talking on, but right now it's all or nothing for comments.
This is how I interpreted Jose's point in comment #2, and I agree with that comment that a more generalized solution would solve both problems. For example, the situation in #14 is the same as the first two options in my rough interface description in #11 (allow but opt in, and opt out). In fact, to finish out the interface with the rest of Jose's suggestions from #2 it could look something like the attached image.
I suppose what is accomplished with these checkbox options could also be done with Actions and Triggers, but from an administrative interface I think it would be awesome to be able to do it all here.
Comment #18
esadot commentedsagannotcarl,
I believe you conveyed your point clearly, unfortunately my hands are tied until such interface (get notification only for comments per content type) is supported by the core notification module.
Comment #19
MedicSean37 commentedesadot,
Hey the interface is great. I think I've found a bug though. Right now I have content types like event, article, classified_ad, commentary, site_news, allowed to be subscribed to. I want the event & classified_ad to autosubscribe at registration. Well in your UI, only the event, article, and commentary content types check boxes are enabled to be marked for autosubscription. The classified_ad & site_news checkboxes can not even be marked for auto subscription, even though they are enabled in the notification module. I think the pattern here is the underscore. It also may be the user viewable name "Classified Ad" & "Site News" with the space, i'm not for sure which. I've tried this will all the other behind the scenes content types, and the pattern matches with the issue of an underscore or space.
I hope I explained that well enough.
Comment #20
sagannotcarl commentedI split my suggestion off here #341500: Notify users of specific node events. Hopefully that helps things stay clear and this module keep moving.
Comment #21
esadot commentedHad an issue with spaces in the name.
Comment #22
MedicSean37 commentedThat was quick! Unfortunately I've found another issue. Although now all the appropriate checkboxes are enabled to be marked, when I hit save only the content types with the underscore or space will actually get set for auto-subscription in the refresh page. Types like event & article do not get set even though they were checked to be autosubscribe.
It's a lot of work making a module isn't it?
Comment #23
esadot commentedWell, it works here. To be on the safe side I added a dummy content type (nae dummy) to the default story and page, and they all checked out ok.
Comment #24
MedicSean37 commentedI looked at your code and I've noticed you changed things from $type to $type => $value. I bet since I've used your previous code, the db has the whole $type variable stored instead of $type => $value and from there is getting confused. I'll just clean up the db and see if that fixes the issue. It probably explains why the content types with the space are working, b/c they've not been stored yet.
Comment #25
sagannotcarl commented#21 works great for me.
One question though, is the new tab doing the same thing as the "Set all users to "autosubscribe" by default" checkbox on the Content Subscriptions tab? If not it's a little confusing. Is the tab more like Default Subscriptions?
Comment #26
esadot commentedMedicSean37 - make sense. Sorry for the mess. Please let me know if it works now.
Comment #27
esadot commentedsagannotcarl,
Yes it is. Confusing. They serve two different purposes.
The Notifications Autosubscribe (vs. Notifications Autosubscribe New User - this module) serves as: "It automatically subscribes you content that you either author or comment on - not automatically to everything posted on the site." (http://drupal.org/node/238994#comment-784028)
Obviously I have no control whatsoever over the Notifications Autosubscribe module, but i'd be the first to agree that the Notifications Autosubscribe and this module need to be distinguish clearly. On my part I can change this module description, starting from the module's name, through the module's list page (admin/build/modules), up to the autosubscribe tab (admin/messaging/notifications/autosubscribe).
Suggestions would be appreciated.
Comment #28
sagannotcarl commentedTo me it seems like something about "Default" makes sense.
Here's a couple ideas, if any sound appealing.
Default Content Subscriptions (I like this one the best)
Default Content Notifications (makes sense because the module works with the Content Notifications module)
Default User Subscriptions
Default Notifications Options
Default Notifications Subscriptions
Another thought, it may be less clean and easy but what about doing your functionality as a patch to the content subscriptions module? I don't know what technical issues are involved but from an interface perspective I think it makes sense.
Or maybe even better, you can leave your module as it is but from an interface perspective have it add checkboxes next to the content types on the Content Subscriptions tab? Sort of like the mockup I posted above except only the radio buttons (and not the extra checkboxes that I was suggesting for the other features).
Again, not a technical suggestion but from a non-programmer user of your module.
Comment #29
tallsimon commentedthis looks very handy, watching with interest :-)
Comment #30
tallsimon commentedOh and while we're perfecting notifications :-), does this module set the interval for the subscription? I am thinking
- Notifications Autosubscribe New User --> instant notifications for all forums posts (so that users can use Mail to Web to reply to posts)
- Daily (digested) posts as the default for other subscriptions on the site (the ones users choose to subscribe to).
Or perhaps I should put a separate feature request for setting default interval by content type?
Comment #31
esadot commentedtallsimon - I agree, it does make sense to add interval, and digest as configurable parameters per content type, unfortunately I'm afraid I don't have the time right now to do that. On the other hand, if someone would like to chip-in, and provide a snippet of the new configuration form, in the form of table, I'd be happy to incorporate into the module.
I believe the new configuration form should comprise of a table with 4 columns: checkbox, content type name, interval and digest. I looked at the notification code and find that _notifications_send_intervals() provides the interval, and a generic table form: notifications_table_form.
Comment #32
tallsimon commentedThank you for considering it, wish I had the skills to help code, I can only test and feed back though.
Simon
Comment #33
STNyborg commentedI agree with you all that the new addition from esadot looks very promising when handling user subscriptions.
However I am not sure if both issues (joined together as one issue in #4) are met with this new addition. I am semiclose to launching a new updated website (ver. 6.x) with 300+ already registred users and I want to add a newsletter that by default is subscribed to by all users. I would be happy to avoid to subscribe every single user one by one to the new newsletter, and look forward to hear if anybody else has found a working solution to this mass subscribing issue.
Svend
Comment #34
esadot commentedAn attempt to subscribe registered users.
Comment #35
esadot commentedPosting a new version for review (please note the name change, as the module encompass new and registered users). This version introduce no real new feature, but adhered to drupal module design guideline.
Regards,
Comment #36
jose reyero commentedThe feature is certainly cool, and it may be interesting either if you want to build on it and publish a stand alone module, or if you want to rework it as a patch for the existing modules (notfications_autosubscribe). Some comments about the implementation:
- It needs consistent naming for the functions to avoid future namespace collisions, all of them should start with the same prefix.
- You don't need confirmation page for the admistration settings. And a cleaner forms API implementation would be desirable too (just form callback, form submit functions).
- Present the pre-settings on the user registration page so they can at least opt-out when registering.
Comment #37
esadot commentedThanks for the feedback.
Attached please find v2. I believe I addressed above comments, and also added support for interval settings.
Comment #38
MedicSean37 commentedesadot, Again, I would like to thank you for your hard work on this. It really is a helpful tool for me.
Comment #39
tallsimon commentedbrilliant thanks i'm trying this out
Comment #40
edvanleeuwenThis works great, thanks for sharing!
Comment #41
apt94jesse commentedAwesome work everyone. I stumbled across this after I realized it wasn't included in the core notifications module. I was getting worried because this was the main function I needed. Thanks so much for contributing.
Comment #42
danepowell commentedSubscribing and watching with great interest...
Comment #43
esadot commenteddanep et al,
Right now I've nothing on my plate as to new features. If you feel that other capabilities would enhance the module, please feel free to shot them here, and i'll see what i can do. For instance, some discussions took place considering the option of getting notification for new users.
Regards,
Comment #44
danepowell commentedThe only two suggestions I have are as follows:
1) I haven't had a chance to try the patches above, but from the descriptions it sounds like you can only auto-subscribe new users to content types - what about taxonomy terms or authors?
2) It would be wonderful to have a "mass subscription" admin user interface - that is, a page where the admin can see all users (whether or not they have subscriptions) and subscribe or unsubscribe them en masse.
Comment #45
RobertNelsonVance commentedHi-
I'm using the notifications_user_autosubscribe.d5.v02 module.
This is a great contribution and I wonder why it's not been committed to the module yet.
In any event, I found it desirable to remove the fieldset from the user registration form... while I want all registrants to automatically be enrolled in the subscriptions, I already had a rather long registration page with profile fields and did not want to make it even longer by having the subscription options there as well.
At first I thought I'd just collapse the fieldset, so in your module I added the following to form user_register_content_type:
Then I decided that I really didn't want them to access it at all because in this context my content type names might not be clear to my user base.
So I then added the following to my CSS:
Of course this solution is only useful if this is the only fieldset that is collapsed... otherwise all of the collapsed fields would also disappear.
I'd like to see a real solution to this added to the module.
Thanks!
Comment #46
RobertNelsonVance commentedOops, I accidentally changed the Issue Title.
Switched it back. Sorry.
Comment #47
RobertNelsonVance commentedHi-
I'm using the notifications_user_autosubscribe.d5.v02 module.
Again, this is a great contribution and I wonder why it's not been committed to the module yet.
Despite my previous post, while this particular request won't help me for how I'm using your module, it might help someone else.
I noticed that the module displays the subscription settings on the user registration page in the middle of my other profile field categories. I installed the http://drupal.org/project/profile_category_weight module to try to resolve this. The notifications_user_autosubscribe, however, does not show up in the profile_category_weight settings.
I found that no matter what arrangement I tried in the profile_category_weight module, I couldn't get the registration form to render in the order I wanted.
Some users may find a feature that allows them to set the weight of the notifications_user_autosubscribe module. I manually hacked this in by adding the following to user_register_content_type in your module:
Of course this accomplished what I wanted. However, I am a firm believer that hacking modules is really bad. So any further contribution on this note might help out other Drupalers.
Thanks!
Comment #48
esadot commentedRobertNelsonVance,
I believe the issues you've brought up are valid, and I'll do my best to address. I'm thinking of adding admin configurable options to (a) drop the opt in option from the user registration form, and (b) set the weight.
Why it's not part of the core notification module? well, I've contact the notification maintainer, solicit adding the module to the core w/o success, i've also approached drupal core to get an approval for new module, again w/o success.
Regards,
Comment #49
thijsvdanker commentedWorks great for me esadot, exactly what I was looking for, thanks!
Comment #50
jose reyero commentedI've just added this new notifications_custom module that is kind of the same feature implemented with a more generic approach, please take a look at it.
Comment #51
giorgio79 commentedThanks I was looking for this functionality as well.
At the moment I have http://drupal.org/project/notify module for this purpose and it works very well, and I hope I will be able to switch to this as I am using notifications for taxonomy terms.
At notify module users at registration have an additional checkbox saying
"Daily Email News Notifications
Receive email notifications of news posted to this site. Notifications are sent every 1 day" etc etc."
Not sure if this is implemented yet, but would be great.
I am also wondering if the template could be customizable so we could include blocks like:
Most viewed content today
Users who viewed your profile
etc etc, I believe this would be more a token integration...
Comment #52
jose reyero commentedWell, this feature is implemented then.
Notes:
- Are we missing any feature here about the original issue? (Subscribe new users to all content)
- This notifications_custom is just the starting of a bigger UI revamp.
@giorgio79
That most viewed content / users visiting profile / etc would be too complex to fit in this simple field/value oriented schema. I'm afraid you'll need a custom module for that.
Comment #54
aequor commentedHi esadot,
Long time back it was closed, i would like to reopen with my feature request...
I have a requirement in Drupal 5. Using Notifications modules, i need to give option to user subscribe to his interested keywords.
In depth, user will have option to enter his interested keywords in a text box. From now onwards if any new content created or updated into site he should get mail notification based on his selected interval in the user/edit page.
Provide me some solution to sort out the above issue.
Thanks,
Ram
Comment #55
danepowell commentedHi Ram
That's not a particularly easy task, nor is it one that fits well with this issue- I would suggest opening a separate issue as a feature request, possibly in the notifications_extra module. However, I doubt that many new features will be added to the 5.x release with 7.x pending, and notifications_extra does not support 5.x at all.
Comment #56
TheDanScott commentedHi All,
I've done a little tinkering with esadot's drupal 6 notifications_user_autosubscribe module v2 (at #37) and I've added an option to remove the content type checkboxes on the user registration page, as well as providing an extra (optional) field to allow users to choose their preferred messaging method at registration time.
The "messaging method" field allows users to select a method other than plan text email (such as mimemail for HTML email).
Also, the administrative option that applies the default subscriptions to current users now respects those users' "default messaging method" setting (rather than subscribing everyone with plain text email only).
I've left space for an alternative to the series of content type checkboxes on the registration page, which I would imagine would take the form of a simple "yes I would like to receive email notifications" checkbox. I just haven't implemented it yet. If anyone would like that option for the registration page let me know and I'll stick it in.
Code is attached.
Comment #57
nbluto commentedThank you for doing this!
I love that I can take the check boxes out of the registration form! Thank you so much.
Comment #58
janadamGreat module ...
Could somebody imlement user roles option ? maybe with permissions.
Thanks again.
Comment #59
minus commentedgreat module!
:-)
Comment #60
leenyx commentedHi there,
Great module, I am developing a portal and we need to have automatic subscriptions for all users and a catch-up email with all the latest nodes and comments send weekly. I have tried the combination of all the modules suggested, so far the only results I got come from the notify module, but unfortunately it doesn't automatically subscribe all users but again list the options in the user page.
the notifications_user_autosubscribe does actually work and it's promising. One thing I've noticed broken in my end is the option to subscribe all registered users,
Registered users
Subscribe registered users to above enabled content types. This action cannot be undone!
I am trying to enforce subscriptions to all users but there is nothing happening after I click the button. Can someone guide me? Am I doing something wrong, or is it just a bug in the code?
I am using the notifications_user_autosubscribe d6 v2.1, is it going to be officially release?
Jose, I think you mentioned that the custom_notifications could do this functionality, can you guide me on how to set it up?
Thanks a lot!!
Comment #61
jellicle_it commentedHello leenyx,
i'm playing with this module too and i've encountered the same issue.
This is a patch that fixes the broken "subscribe all registered users" function.
The patch also fixes an error in the db_query statement.
Hope this helps, cheers!
Daniele
Comment #62
Anonymous (not verified) commentedI have recently tried this module with the patch and seems to work great. One thing that would be nice is to include being able to subscribe registered users to TAGS as well. I currently don't allow users to change Announcements and Events, which are content types, but they can turn off Forum topics which are TAGS. The issue that I have is that when trying to fix an update problem Notifications was uninstalled along with the Drup_Notifications table. I now need to restore all the Forum Topics notifications to a default condition. This module worked well for the content types if only the TAGS could be accomplished. I guess I'm being greedy.
Comment #63
jose reyero commentedThis feature is provided by the "Custom Subscription" module, check out 4.x version.
Not to be backported to 2.x branch.
Comment #64
lhubbert commentedIn the free hours that I now have been today and my site community site launch in two weeks, I shall drink a toast to everyone who contributed this module. Without it, I would be clicking checkboxes for over 350 new users as I manually subscribed them to content notifications. Bravo and thanks.
Comment #65
hedac commentedI imported a lot of users manually. Is it easy to subscribe to all current users once from administration and not only the new ones automatically?
edit: I found it! in users list there is a function to subscribe to the users... I didn't know. great!
Comment #66
sumit_drupal commentedThis module is great but i want to send notification of newly published content but using this all registered user getting bulk of mails of all earlier published contents.
Comment #67
Skidz commentedsubscribe