ShareThis link doesn't show in IE7 (link area) in nodes and teasers. On the other hand, PingThis works.

Anyone else can confirm? Stupid M$FT!

CommentFileSizeAuthor
#14 sharethis_comma_fix.patch822 bytescglusky

Comments

spiffyd’s picture

spiffyd commented

BTW Firebug identified this error with ShareThis not sure if module is related but I'll shoot:

"http://w.sharethis.com/widget/?tabs=web%2Cpost%2Cemail&charset=utf-8&sty..."

lineNumber
53

message
"node is null"

name
"TypeError"

stack
"(null)@http://w.sharethis.com/widget/?tabs=web%2Cpost%2Cemail&charset=utf-8&sty...\n@http://w.sharethis.com/widget/?tabs=web%2Cpost%2Cemail&charset=utf-8&sty...\n"

strangeluck’s picture

strangeluck commented

having the same issue. can confirm it also does not show up in ie6. any help would be greatly appreciated.

snowball43’s picture

snowball43 commented
Status: Active » Closed (fixed)

This is not a ShareThis for Drupal problem, this exists for all ShareThis widgets including one for Wordpress.

spiffyd’s picture

spiffyd commented
Status: Closed (fixed) » Active

The problem still exists even if the source is different.

nodegate’s picture

nodegate commented

Same error here on IE7.

nodegate’s picture

nodegate commented
Status: Active » Fixed

Here's the solution. Maintainer please update:

You have an extra comma after the url object property.

SHARETHIS.addEntry({
title:'UPDATE! Missing Robot, post prime suspect',
url:'http://lilyonthedustbin.com/2008/06/20/missing-robot-post-prime-suspect/', <--extra ,
}, {button:true} );

Remove that comma and that should fix it!

BuyBub.com’s picture

BuyBub.com commented

I updated sharethis.module according to this and it works perfectly for IE7. Could please the maintainer update the source for this module?

Thanks.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

spiffyd’s picture

spiffyd commented
Status: Closed (fixed) » Reviewed & tested by the community

Can someone verify this has been fixed in the latest dev before closing thread? Thanks.

gjperera’s picture

gjperera commented

The solution above has worked on my site....thanks for posting

donkasok’s picture

donkasok commented

Its working... thanks dude

spiffyd’s picture

spiffyd commented
Status: Reviewed & tested by the community » Patch (to be ported)

Needs to be rolled into the next CVS.

cglusky’s picture

cglusky commented

I just downloaded 1.3.3 and the extra comma in question seems to be generated on line 139 in sharethis.module

 '#value' => "<script type=\"text/javascript\">
                SHARETHIS.addEntry({
                title:'$ntitle',
                url:'$linkage' //, extra comma?
                }, {button:true} );
                </script>",

Going to test it shortly. If it works then I will create a patch.

R,
Coby

cglusky’s picture

cglusky commented
Assigned: Unassigned » cglusky
Status: Patch (to be ported) » Reviewed & tested by the community
StatusFileSize
new sharethis_comma_fix.patch822 bytes

Here's the patch. Sorry for the delay. You can apply this patch or just edit the sharethis.module file and delete the extra comma around lines 139 and 170 - It appeared twice, once for node hook and once for link hook.

R,
Coby

robloach’s picture

robloach
he/him
commented

Yup.... JavaScript doesn't really like our PHP array coding convention.

robloach’s picture

robloach
he/him
commented
Status: Reviewed & tested by the community » Fixed

Stuck it in a drupal_to_js() function..... http://drupal.org/cvs?commit=159316

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.