Download & Extend

Little string cleanup...

Project:FileField
Version:6.x-3.x-dev
Component:User interface
Category:task
Priority:minor
Assigned:Moonshine
Status:closed (fixed)

Issue Summary

"Images must be smaller than @max_size pixels"

should say:

"Images larger than @max_size pixels will be scaled"

--------------------

"Must be an JPEG, PNG or GIF image"

should say:

"Must be a JPEG, PNG or GIF image"

-------------

and "bigger" -> "larger" for consistency. (and it's a nicer word :) )

AttachmentSize
filefield-strings.patch959 bytes

Comments

#1

Status:needs review» needs work

they're only scaled if core has an enabled image toolkit... the other bits look good though.

#2

Ahhhh.. I'll make that one conditional then, just need to look at the code a bit.

#3

Status:needs work» needs review

Updated version..

AttachmentSize
filefield-strings-v2.patch 1.1 KB

#4

Status:needs review» fixed

thanks, committed to HEAD.

#5

Status:fixed» active

Sorry I missed this one, but I think it's worth adding... Nice for "exact" size requirements like ads.

AttachmentSize
filefield-strings-exact-size.patch 819 bytes

#6

Status:active» needs review

oops wrong status.

#7

Status:needs review» fixed

thanks, committed to HEAD.

#8

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.