1.8 release - Parse error: unexpected ',' in nodereference.module

mariuss - September 4, 2008 - 20:24
Project:Content Construction Kit (CCK)
Version:5.x-1.8
Component:nodereference.module
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed
Description

There is an extra closing parenthesis at line 330, this completely breaks your site if you are using nodereference.

#1

spatz4000 - September 4, 2008 - 20:40
Status:active» needs review

I can confirm.
here is a patch

AttachmentSize
nodereference.module.patch 822 bytes

#2

dgorton - September 4, 2008 - 21:25
Status:needs review» reviewed & tested by the community

+1. Can also confirm. Marking as RTBTC.

#3

cyberswat - September 4, 2008 - 21:54

Isn't the function called content_filter_xss and not content_filter_xsst?

#4

John Morahan - September 4, 2008 - 21:55
Title:extra ) at 330» missing ( at 330
Status:reviewed & tested by the community» needs review

Right, it's not an extra ')' it's a missing '('

AttachmentSize
nodereference.304118.patch 588 bytes

#5

dgorton - September 4, 2008 - 21:58
Title:missing ( at 330» extra ) at 330

Ack - I was too quick to chime with my rtbtc. Back to code needs review.

I believe the correct line is actually:

'#description' => content_filter_xss(t($field['widget']['description'])),

Adding a '(' before the 't' function, not pulling the closing ')'.

#6

John Morahan - September 4, 2008 - 22:03
Title:extra ) at 330» missing ( at 330

restoring title after crosspost

#7

yched - September 4, 2008 - 23:30

Triple doh.
Fixed in 1.9 :-(

Sorry about that...

#8

yched - September 4, 2008 - 23:30
Status:needs review» fixed

#9

yched - September 5, 2008 - 14:06
Title:missing ( at 330» 1.8 release - Parse error: unexpected ',' in nodereference.module

Better title so that people can find it more easily

#10

Anonymous (not verified) - September 19, 2008 - 14:12
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.