Download & Extend

1.8 release - Parse error: unexpected ',' in nodereference.module

Project:Content Construction Kit (CCK)
Version:5.x-1.8
Component:nodereference.module
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

There is an extra closing parenthesis at line 330, this completely breaks your site if you are using nodereference.

Comments

#1

Status:active» needs review

I can confirm.
here is a patch

AttachmentSize
nodereference.module.patch 822 bytes

#2

Status:needs review» reviewed & tested by the community

+1. Can also confirm. Marking as RTBTC.

#3

Isn't the function called content_filter_xss and not content_filter_xsst?

#4

Title:extra ) at 330» missing ( at 330
Status:reviewed & tested by the community» needs review

Right, it's not an extra ')' it's a missing '('

AttachmentSize
nodereference.304118.patch 588 bytes

#5

Title:missing ( at 330» extra ) at 330

Ack - I was too quick to chime with my rtbtc. Back to code needs review.

I believe the correct line is actually:

'#description' => content_filter_xss(t($field['widget']['description'])),

Adding a '(' before the 't' function, not pulling the closing ')'.

#6

Title:extra ) at 330» missing ( at 330

restoring title after crosspost

#7

Triple doh.
Fixed in 1.9 :-(

Sorry about that...

#8

Status:needs review» fixed

#9

Title:missing ( at 330» 1.8 release - Parse error: unexpected ',' in nodereference.module

Better title so that people can find it more easily

#10

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

nobody click here