There is an extra closing parenthesis at line 330, this completely breaks your site if you are using nodereference.

CommentFileSizeAuthor
#4 nodereference.304118.patch588 bytesjohn morahan
#1 nodereference.module.patch822 bytesstevenpatz

Comments

stevenpatz’s picture

stevenpatz
he/him
commented
Status: Active » Needs review
StatusFileSize
new nodereference.module.patch822 bytes

I can confirm.
here is a patch

dgorton’s picture

dgorton commented
Status: Needs review » Reviewed & tested by the community

+1. Can also confirm. Marking as RTBTC.

cyberswat’s picture

cyberswat commented

Isn't the function called content_filter_xss and not content_filter_xsst?

john morahan’s picture

john morahan commented
Title: extra ) at 330 » missing ( at 330
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new nodereference.304118.patch588 bytes

Right, it's not an extra ')' it's a missing '('

dgorton’s picture

dgorton commented
Title: missing ( at 330 » extra ) at 330

Ack - I was too quick to chime with my rtbtc. Back to code needs review.

I believe the correct line is actually:

'#description' => content_filter_xss(t($field['widget']['description'])),

Adding a '(' before the 't' function, not pulling the closing ')'.

john morahan’s picture

john morahan commented
Title: extra ) at 330 » missing ( at 330

restoring title after crosspost

yched’s picture

yched commented

Triple doh.
Fixed in 1.9 :-(

Sorry about that...

yched’s picture

yched commented
Status: Needs review » Fixed
yched’s picture

yched commented
Title: missing ( at 330 » 1.8 release - Parse error: unexpected ',' in nodereference.module

Better title so that people can find it more easily

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.