Download & Extend

5.x-1.7 to 5.x-1.8 upgrade array_merge and foreach warnings

Project:Content Construction Kit (CCK)
Version:5.x-1.8
Component:upgrade path
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

* warning: array_merge() [function.array-merge]: Argument #2 is not an array in /.../core/update.php on line 309.
* warning: Invalid argument supplied for foreach() in /.../core/update.php on line 542.

Using PHP 5.2.4.

Comments

#1

i've got the same warnings, but nothing critical happened; the update went through, modifiyng all tables as supposed, and i haven't seen any further errors since...

#2

I can confirm.

#3

Status:active» needs review

Update 1010 is missing a mandatory return value. Attached patch is untested.

See also: #167610: Standardize the return values of updates

AttachmentSize
patch.patch 499 bytes

#4

Status:needs review» fixed

Hm, that and #304118: 1.8 release - Parse error: unexpected ',' in nodereference.module , I did a great job, really.
Fixed in 1.9...

To the people that were bitten by this : these warnings are harmless - your db is fine, and there's no need to re-run update.php

Sorry about that.

temp

Automatically closed -- issue fixed for two weeks with no activity.

#5

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

nobody click here