Patch for IE6 issues

cooperq - September 4, 2008 - 21:04
Project:Abessive
Version:5.x-1.0
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs work
Description

Hi,
I have a patch for ie6, here it is, insert the following lines on line 10 of index.tpl.php just below php print $scripts:

<!--[if lt IE 7]>
    <style type="text/css" media="all">@import "<?php print base_path() . path_to_theme() ?>/fix-ie.css";</style>
    <![endif]-->

and then create the file fix-ie.css with the css shown here:
#left {
  width: 200px;
  margin-left: -1260px;
  padding: 0px 10px;
  right: 230px;
}

#1

nicholasThompson - September 5, 2008 - 09:47
Status:reviewed & tested by the community» needs review

I'd like to test this... I'm a little concerned about the -1260px offset. It looks a little like its hard coded for a fixed width.

Thanks for the patch though, I'll happily commit this in if it works!

#2

nicholasThompson - September 5, 2008 - 10:57
Status:needs review» needs work

I've implemented this tweak on my development site however the left menu still behaves abnormally in IE6. Here is my theme's file listing...

block-footer.tpl.php
block-header.tpl.php
block.tpl.php
box.tpl.php
comment.tpl.php
CVS
fix-ie.css
logo.png
node.tpl.php
page.tpl.php
screenshot.png
style.css
template.php

I added the following to fix-ie.css

#left {
  width: 200px;
  margin-left: -1260px;
  padding: 0px 10px;
  right: 230px;
}

and the top of page.tpl.php now looks like this:

<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="<?php print $language ?>" lang="<?php print $language ?>">
  <head>
    <title><?php print $head_title ?></title>
    <?php print $head ?>
    <?php print $styles ?>
    <?php print $scripts ?>
    <!--[if lt IE 7]>
    <style type="text/css" media="all">@import "<?php print base_path() . path_to_theme() ?>/fix-ie.css";</style>
    <![endif]-->
  </head>

  <body<?php print phptemplate_body_class($sidebar_left, $sidebar_right); ?>>

Any idea's?

#3

adresaklumea - September 19, 2008 - 09:59

I'm thinking to another approach, inspired by foliage theme

AttachmentSize
abessive.zip 18.22 KB

#4

nicholasThompson - February 16, 2009 - 16:09

I see - the approach of wrapping everything in excess markup...

Thanks for the resource - I'll resort to that if I cant find a fix, but I really dont want to pollute the markup TOO much (I know I've got lots of divs for the rounded corners though ;-) hehe)

 
 

Drupal is a registered trademark of Dries Buytaert.