The latest version of Views 2 (the HEAD version after RC1) has broken our Views integration. See http://angrydonuts.com/attention-views-api-developers

We need to implement the new hooks and split our views integration into separate files. Perhaps it'd be a good time to create an "includes" directory also, as we're accumulating quite a few of them now.

Comments

mooffie’s picture

I wasn't aware of this. I'll look into this later.

Perhaps it'd be a good time to create an "includes" directory also

(Yes, we're starting to have a jungle there.)

mooffie’s picture

Priority: Critical » Normal

We want to have at least one beta that's compatible with the official Views release.

So this issue isn't a beta breaker. I'm demoting this to 'normal'.

mooffie’s picture

I see Merlin has just released an RC2. So this is back to 'critical'.

mooffie’s picture

Priority: Normal » Critical

I see Merlin has just released an RC2. So this is back to 'critical'.

mooffie’s picture

After checking the status of various modules, I decided it's best to release Beta4 before upgrading our Views support.

We have conservative users who use our "official" releases. So they're using "official" releases of other modules too, and, since many of these don't support Views' RC2 yet, they're going to stick with RC1 for a bit.

mooffie’s picture

What about the files layout?

You aren't here these days, so I can't ask you for your preferences.

I think one good choice is to have a 'flag_views' folder --as if our Views support were a separate module-- and in it have a 'handlers' folder, and perhaps a 'views' folder to put the default views in (a la Organic Groups).

But perhaps you'll consider this too revolutionary. Then I could put the Views support in 'includes/views' and 'includes/views/handler' (a la CCK). But perhaps you'll consider the extra 'views' folder unneeded.

So I'll put it directly in the 'includes' folder.

mooffie’s picture

mooffie’s picture

Status: Active » Fixed

Fixed.
http://drupal.org/cvs?commit=140360
http://drupal.org/cvs?commit=140361

I've added three lines at the bottom of flag.views.inc to makes it work with the old version of Views as well.

chadchandler’s picture

I can confirm that this is fixed.

Also, I think it's time to get a tip-jar going for Moofie ...

quicksketch’s picture

Agreed :D

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.