Hi there,

upgrading from version 5.x.1.0 to version 5.x.2.0 makes it impossible to edit nodes and the collapsiblock module doesn't work anymore.

Any ideas?

Thanks,

JanPieter

Comments

alank’s picture

I noticed this too... get an error

"Too much recursion" return this._filter( arr.constructor == Array ? arr.join(",") : arr ); in compat.js Line 63.

But not sure if they are related. If I disable the jQuery module (Admin->modules...) the collapsible blocks work again.

alank’s picture

OK, got it I hope. But I need you all to test very carefully to make sure...

You are probably like me, have the old compat-1.0.js and collapse-fix.js. Remove these files (but your testing so put them somewhere where you can put them back again). This should fix the colapse issue since the new stuff conflicts with these old 1.0 patches. Am I making sense?

So in home/misc remove (place them somewhere) compat-1.0.js and collapse-fix.js and that should be all.

You might also want to remove the following code which is most likely in page.tpl.php as these were used for calling, or including, the two files...

<!-- REMOVE these if you are using jquery-update!! -->
<script type="text/javascript" src="<?php print $base_path ?>misc/collapse-fix.js"></script>
<script type="text/javascript" src="<?php print $base_path ?>misc/compat-1.0.js"></script>

HA! Doesn't the comment hint it all eh?

Other then that, all I have to say is nice job on the jQuery stuff, great code and service to us all. I'd just suggest changing the instructions from "Copy all *.js files from the jquery_update/misc folder... " to say "Move all *.js files from the ...." as I'm just kinda concerned that two copies of the scripts might cause confusion when updates come in the future.

Thanks and let me know if this doesn't fix your problem.
Andrew.

jippie1948’s picture

Dear Andrew,

thanks for responding.

= the old compat-1.0.js and collapse-fix.js. were already removed.
= the code you mentioned I couldn't find in any file...

= I removed the misc folder from the jquery update folder: no difference.

All the best,

JanPieter

Leeteq’s picture

Subscribing.

terryallan’s picture

This may also be my problem.

I have reported this elsewhere

Collapsiblock no longer working.

I upgraded jstools around the same time.

Tabs are not working with Panels and Activemenu is not working.

I have installed components again but no joy.

ani7a’s picture

StatusFileSize
new3.56 KB

Hi!

I'm newbie to Drupal, but just to get this blocks working i've replaced collapsiblock.js with the one attached.

Just added de main code into

$(document).ready(function(){

});

Hope it helps

Bye!

terryallan’s picture

StatusFileSize
new41.7 KB
new29.84 KB
new35.99 KB

I have just replaced the jquery-update 2 with jquery-update 1 and collapsiblock has come back. I am using drupal 5.7 and so I had to download drupal 5.7 again to replace the .js files in site/misc folder.

With jquery-update 2 in place I also lost the content of the Panes associated with the Tabs in Organic Groups Panels. That at least has now been restored by re-installing jquery-update 1.

I now have one remaining problem. The active menu system which is part of jstools is not mapping properly onto nodes which are used as the content of Panes in Organic Groups Panels.

The attached image "Correct.gif" shows the menu system expanded and with all menu items as they should be. The menu has been set to be expanded if 'children' exist.

The attached image "wrong.gif" shows the menu system expanded using active menus. The problem is clear, the parents adopt children of other menu items. Bizarre!

The menu details are found in "menus.gif" attached for confirmation. Screenshot from Administration/Menus.

Clearly there can be a problem with jquery-update 5.x-2.0 but there is also another gremlin in the system. Could be jstools!

Any help, advice, thoughts and so on will be most welcome.

I hope the above is of some help to others.

vegeneric’s picture

subscribe... upgraded to jquery_update 2.0 and my collapsiblocks stopped working as well. i need the latest jquery b/c i'm trying to fix a MAC / FF2 glitch in thickbox (http://drupal.org/node/201026)... so i'm hoping there's a solution to this issue.

Anonymous’s picture

Status: Active » Closed (won't fix)

I do not see this as a jquery_update issue.

With ani7a's post, that adds to it not being a jquery_update issue.

a contrib module is responsible for its own js code. A jQuery script can easily be compatible with 1.0.3 and 1.2.6.

Regarding alank's comment about "moving the js files", we keep clones because we compare the files to make sure the user installed the js files properly. This is how jquery_update has always worked. I just changed it from taking the 1 jquery.js file to copying every js file from a misc/ folder in the module, to the core misc/ folder.

Leeteq’s picture

Ok, so continuing in the bug report on the Collapsiblock module:
http://drupal.org/node/311754

sdsheridan’s picture

I've looked for the items described here in directories and page.tpl.php, tried the new collapsiblock.js from #6, and still doesn't work. Blocks are not collapsing, and the indicator and hotspots are missing in the block titles.

At the same time, fieldgroup-tabs also stopped working. Something's not right somewhere...

shawn

jippie1948’s picture

After I updated Javascript-Tools to version 5.x-1.2, I tried JQuery Update 5.x-2.0 again and this time everything worked fine!

Thanks for all the good work!

JanPieter

indiapoly’s picture

Title: Upgrade to 5x.2.0 breaks edits and collapsiblocks » Also In case of drigg Module..!! Upgrade to 5x.2.0 breaks edits and collapsiblocks
Issue tags: +jQuery, +JavaScript, +Drupal, +theme, +drigg, +page, +drigg_theme, +jquery_update

We got this error in JAVA Error console.. After few minutes later i got this issue for drigg theme.I just changed code :-

<!-- REMOVE these if you are using jquery-update!! -->
<script type="text/javascript" src="<?php print $base_path ?>misc/collapse-fix.js"></script>
  <script type="text/javascript" src="<?php print $base_path ?>misc/compat-1.0.js"></script>  

to
IN page.tpl.php under /themes/drigg_theme

<!-- REMOVE these if you are using jquery-update!! -->
<?php
  if(!module_exists('jquery_update'))echo '<script type="text/javascript" src="'.$base_path.'misc/collapse-fix.js"></script>
        <script type="text/javascript" src="'.$base_path.'misc/compat-1.0.js"></script>';
  ?>
Vote_Sizing_Steve’s picture

Spent the better part of today trying to figure out what any of this means, and why I even installed this module in the first place. Please fix, or tell me how to uninstall properly so I have my website back (collapsiblocks stuck on hiding important content).