Project:Activity Stream
Version:6.x-2.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:akalsey
Status:postponed

Issue Summary

When a site's favicon is missing, the site's title appear instead.

i added something like this: onerror=\'this.src="http://www.sitename.com/drupal/misc/feed.png"\'

in front of this: height="16" width="16"/>

inside the theme_activitystream_feed_icon function in the activitystream_feed.module, and it solved the problem (i only use the feed module). This is more a workaround than a fix, and using javascript may not be such a good idea, but it work for me.

Comments

#1

Title:Bug when site favicon is missing» Cache favicons in feed module
Version:6.x-1.x-dev» 6.x-2.x-dev
Category:bug report» feature request
Assigned to:Anonymous» akalsey
Status:active» postponed

I think what should be done here is download the remote icon and display the downloaded copy. If the file can't be downloaded and the local copy doesn't exist, display a placeholder image.

It would also be a good idea to convert the ICO files to pngs when they're downloaded.

#2

+1