Posted by wesku on September 6, 2008 at 10:07am
| Project: | AddThis |
| Version: | 6.x-2.3 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | wesku |
| Status: | closed (won't fix) |
Issue Summary
This happens when
- Dropdown is disabled
- Display in node teasers enabled
- Addthis button is listed in a view (or any teaser listing)
Caused issue:
- Addthis button shares view url and title instead of the node.
Temporary fix:
- Disable display in teasers or enable dropdown
Comments
#1
Does anyone have any real problems with this?
#2
Yeah, we're having a real problem with this issue. We love AddThis and use it throughout the site. Our front page displays a view of items, output in Node style. We want the AddThis button on each of these items, and the buttons show up, but they add the site url rather than their individual node urls. Is there any way to set it up so they share their proper node urls?
Thanks!
#3
#4
I have a site where the home page is a View using Row Stlye: Node, and every node on the page links to the homepage (view URL) instead of the NODE URL.
Is there any chance we could get a quick patch for this?
Or work-around? I take it there is none because were using a view :-(
#5
ChrisRut: Have you tried our views integration or are you displaying the link just in node links?
#6
i have a fix for this, and i'm puzzeld about the old code.
basically, if there is a node provided, we should use the title and url of the node - and not the pages title and url.
i think this might be based on the assumption, that if a node is not in teaser view - the active url must be the actual link to this node - which is not always true.
(we show some nodes in a popup - so the link in addthis would be the base url - not the nodes!)
this patch should fix it.
#7
It works great.. Very cool when using views.. Thanks... I think this should be committed
#8
Personally, I like the block being thrown into the Content region and having it always pull page title/url. Then, each node teaser shows a node title/url as dictated by this patch.
However, some sites may not want to share the node as a link but would prefer a link to the view listing the node whose addthis was clicked (even if the view is not a page-- like in Panels for instance). Rather than making the decision system-wide, it would be nice to have this configurable in the Node->AddThis field that is exposed in Views (and maybe wherever else it is appropriate).
#9
If you provide this patch for the latest 6.x-2.x I can test it.
#10
You got yourself a pretty damn good and suffusion peace of work up ahead of you down here o_O Good lack to you in achieving your noble goal...
----------
"What is wanted is not the will to believe, but the will to find out, which is the exact opposite."-- Bertrand Russell, Skeptical Essays (1928)
#11
I agree that there is a problem, but the problem has to do with context of the button. This patch might fix the issue for some sites but as texas-bronius points out in #8 it might also break the current functionality for others. I don't want to change this functionality in 2.x version of Addthis because it's so likely to cause many new issues. The "context problem" will be solved in development version of this module and backported to 2.x if applicable.
Unfortunately if this is a issue on your site right now you have to use this simple patch provided by neurovation.kiwi.