Updated commentrss to 6.x-1.1 from 6.x-1.0 and the site-wide comment feed /crss did not work anymore, resulting in page not found error.

The following line in commentrss_handler causes the problem:

if (strlen($type) && variable_get('commentrss_'. $type, $default))

For /crss feed, $type is '' and strlen() returns 0.

I fixed it for my site with the following change:

85c85,88
<   if (strlen($type) && variable_get('commentrss_'. $type, $default)) {
---
>   if (!strlen($type)) {
>     $type = 'site';
>   }
>   if (variable_get('commentrss_'. $type, $default)) {

Comments

filiptc’s picture

filiptc commented
Priority: Normal » Critical

Issue confirmed, patch works.

filiptc’s picture

filiptc commented
Status: Active » Reviewed & tested by the community

Updating status.

toemaz’s picture

toemaz commented

Confirming that the patch works.
A way to avoid the problem, use: crss/site instead of crss for the path.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Committed a slightly different version, will be released soon. Thanks!

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.