version: 6.x
The forms should use theme templates.
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | context-304886.patch | 17.31 KB | steven jones |
| #11 | 304886-11-contexts_list.patch | 17.68 KB | pasqualle |
| #7 | 304886-7-contexts_list.patch | 17.7 KB | pasqualle |
| #7 | 3044886-7-contexts_list.png | 11.98 KB | pasqualle |
| #3 | 304886-contexts_list.png | 28.73 KB | pasqualle |
Comments
Comment #1
pasqualleComment #2
dmitrig01 commentedI'm going to have to disagree with you here - the markup actually isn't complicated at all.
Comment #3
pasqualletheme template file for the admin landing page
additional new files:
context_ui/theme/context-ui-list-contexts.tpl.php
context_ui/help/getting-started.html
context_ui/css/contexts-list.css
Comment #4
pasquallethe missing one
Comment #5
yhahn commentedFYI, this is very interesting, I like some of the ideas (showing the summaries of the conditions/reactions for each context) while I miss some pieces of the old layout (tree indenting made for easy quick scanning).
I'd like to work on this more post 2.0 release -- for 2.1 perhaps?
Comment #6
pasqualleDo you have a good layout idea (mockup) for tree indenting? I would like to implement filters and sort also (like in views), so that could be problematic for the tree layout. But if someone knows a good layout, then please help me here..
Comment #7
pasqualleimproved layout
2 new files moved to the main context_ui directory, to be able to generate one patch file..
Comment #8
dmitrig01 commentedLooks good (visually).
+
+
/*print $widgets;*/no thanks
capitalize comment and adda period at the end
when's that used? it doesn't look like it's used anywhere
Comment #9
pasqualle$widgets should be the next patch which adds sort and filter
you are right about the comment
that $close_div part is closing the last "namespace>attribute" box. If the contexts array would be in a tree presentation, that template would be much readable with two foreach loops (div starting at foreach, div closing at foreach end).
It is possible to create the tree presentation of contexts in the template, but it would require going through the list twice.
Comment #10
dmitrig01 commentedI like that, and you don't need to go through twice, just change
to
Comment #11
pasqualleused:
so it is now possible to easily create a bounding box for the namespace also..
and fixed all the problems from #8
Comment #12
steven jones commentedI've re-rolled this patch for the latest version of context, to enable people to keep working on this if they want.
There are a couple of issues that I can see in the code at a quick glance:
There's a require_once instead of a module_load_include.
The 'getting started' help page has no help in it, this will need to be addressed in a follow up patch.
Comment #13
steven jones commentedPatch attached.
Comment #14
steven jones commentedThis should probably get into 2.x.
Comment #15
steven jones commentedCommitted to CVS: http://drupal.org/cvs?commit=357362 Looks cool!