Comments

pasqualle’s picture

Version: 5.x-1.x-dev » 6.x-1.x-dev
dmitrig01’s picture

Status: Active » Closed (works as designed)

I'm going to have to disagree with you here - the markup actually isn't complicated at all.

pasqualle’s picture

theme template file for the admin landing page

additional new files:
context_ui/theme/context-ui-list-contexts.tpl.php
context_ui/help/getting-started.html
context_ui/css/contexts-list.css

pasqualle’s picture

Version: 6.x-1.x-dev » 6.x-2.0-alpha2
Status: Closed (works as designed) » Needs review
StatusFileSize
new1.69 KB

the missing one

yhahn’s picture

Status: Needs review » Needs work

FYI, this is very interesting, I like some of the ideas (showing the summaries of the conditions/reactions for each context) while I miss some pieces of the old layout (tree indenting made for easy quick scanning).

I'd like to work on this more post 2.0 release -- for 2.1 perhaps?

pasqualle’s picture

Do you have a good layout idea (mockup) for tree indenting? I would like to implement filters and sort also (like in views), so that could be problematic for the tree layout. But if someone knows a good layout, then please help me here..

pasqualle’s picture

Status: Needs work » Needs review
StatusFileSize
new11.98 KB
new17.7 KB

improved layout
2 new files moved to the main context_ui directory, to be able to generate one patch file..

dmitrig01’s picture

Looks good (visually).

+
+ /*print $widgets;*/
no thanks

+  // list contexts (admin landing page)

capitalize comment and adda period at the end

+<?php if (isset($close_div)): ?>
+  </div>
+<?php endif; ?>

when's that used? it doesn't look like it's used anywhere

pasqualle’s picture

$widgets should be the next patch which adds sort and filter

you are right about the comment

that $close_div part is closing the last "namespace>attribute" box. If the contexts array would be in a tree presentation, that template would be much readable with two foreach loops (div starting at foreach, div closing at foreach end).

foreach namespace-attribute
  <div>
  foreach contexts in that namespace-atribute
    //
  endforeach
  </div>
endforeach

It is possible to create the tree presentation of contexts in the template, but it would require going through the list twice.

dmitrig01’s picture

I like that, and you don't need to go through twice, just change

+    $vars['contexts'][] = $item;

to

+    $vars['contexts']["$item->namespace-$item->attribute"][] = $item;
pasqualle’s picture

StatusFileSize
new17.68 KB

used:

$vars['contexts_tree'][$item->namespace][$item->attribute][$item->name] = $item;

so it is now possible to easily create a bounding box for the namespace also..

and fixed all the problems from #8

steven jones’s picture

Title: theme templates » Context UI list page re-theme
Version: 6.x-2.0-alpha2 » 6.x-2.0-beta7
Status: Needs review » Needs work

I've re-rolled this patch for the latest version of context, to enable people to keep working on this if they want.

There are a couple of issues that I can see in the code at a quick glance:
There's a require_once instead of a module_load_include.
The 'getting started' help page has no help in it, this will need to be addressed in a follow up patch.

steven jones’s picture

StatusFileSize
new17.31 KB

Patch attached.

steven jones’s picture

Issue tags: +context-2.x-rc-blocker

This should probably get into 2.x.

steven jones’s picture

Status: Needs work » Fixed

Committed to CVS: http://drupal.org/cvs?commit=357362 Looks cool!

Status: Fixed » Closed (fixed)
Issue tags: -context-2.x-rc-blocker

Automatically closed -- issue fixed for 2 weeks with no activity.