Download & Extend

SimpleTest shouldn't try to upload non files.

Project:Drupal core
Version:7.x-dev
Component:simpletest.module
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Simple addition to check that a file is a file before we try to upload it. At least on OS X trying to upload a directory results in problems.

Some other trailing whitespace cleanups got rolled in by my editor.

AttachmentSizeStatusTest resultOperations
simpletest_real_files.patch2.56 KBIdleUnable to apply patch simpletest_real_files.patchView details

Comments

#1

Status:needs review» needs work

I removed white-space clean-up since that is in several other patches and the rework patch should make in soon (#305077: Rework simpletest backend).

The upload test doesn't pass with this applied.

AttachmentSizeStatusTest resultOperations
simpletest_real_files.patch832 bytesIdleUnable to apply patch simpletest_real_files_0.patchView details

#2

Status:needs work» needs review

ah, seems like the order of operations was getting wacky. this passes all the uploading (upload.module, blogapi.module, user.module) tests.

AttachmentSizeStatusTest resultOperations
simpletest_304940.patch1.13 KBIdleUnable to apply patch simpletest_304940.patchView details

#3

Status:needs review» reviewed & tested by the community

simple fix... still applies.

#4

Status:reviewed & tested by the community» fixed

Committed to HEAD. Thanks!

#5

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.