Download & Extend
Issues

SimpleTest shouldn't try to upload non files.

Posted by drewish on September 6, 2008 at 11:23pm
Project:Drupal core
Version:7.x-dev
Component:simpletest.module
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Simple addition to check that a file is a file before we try to upload it. At least on OS X trying to upload a directory results in problems.

Some other trailing whitespace cleanups got rolled in by my editor.

AttachmentSizeStatusTest resultOperations
simpletest_real_files.patch2.56 KBIdleUnable to apply patch simpletest_real_files.patchView details
Login or register to post comments

Comments

#1

Posted by boombatower on September 9, 2008 at 3:45am
Status:needs review» needs work

I removed white-space clean-up since that is in several other patches and the rework patch should make in soon (#305077: Rework simpletest backend).

The upload test doesn't pass with this applied.

AttachmentSizeStatusTest resultOperations
simpletest_real_files.patch832 bytesIdleUnable to apply patch simpletest_real_files_0.patchView details

#2

Posted by drewish on September 9, 2008 at 6:04pm
Status:needs work» needs review

ah, seems like the order of operations was getting wacky. this passes all the uploading (upload.module, blogapi.module, user.module) tests.

AttachmentSizeStatusTest resultOperations
simpletest_304940.patch1.13 KBIdleUnable to apply patch simpletest_304940.patchView details

#3

Posted by drewish on November 9, 2008 at 2:52am
Status:needs review» reviewed & tested by the community

simple fix... still applies.

#4

Posted by webchick on November 9, 2008 at 3:08am
Status:reviewed & tested by the community» fixed

Committed to HEAD. Thanks!

#5

Posted by System Message on November 23, 2008 at 3:12am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.