SimpleTest shouldn't try to upload non files.

drewish - September 6, 2008 - 23:23
Project:Drupal
Version:7.x-dev
Component:simpletest.module
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

Simple addition to check that a file is a file before we try to upload it. At least on OS X trying to upload a directory results in problems.

Some other trailing whitespace cleanups got rolled in by my editor.

AttachmentSize
simpletest_real_files.patch2.56 KB

#1

boombatower - September 9, 2008 - 03:45
Status:needs review» needs work

I removed white-space clean-up since that is in several other patches and the rework patch should make in soon (#305077: Rework simpletest backend).

The upload test doesn't pass with this applied.

AttachmentSize
simpletest_real_files.patch 832 bytes

#2

drewish - September 9, 2008 - 18:04
Status:needs work» needs review

ah, seems like the order of operations was getting wacky. this passes all the uploading (upload.module, blogapi.module, user.module) tests.

AttachmentSize
simpletest_304940.patch 1.13 KB

#3

drewish - November 9, 2008 - 02:52
Status:needs review» reviewed & tested by the community

simple fix... still applies.

#4

webchick - November 9, 2008 - 03:08
Status:reviewed & tested by the community» fixed

Committed to HEAD. Thanks!

#5

System Message - November 23, 2008 - 03:12
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.