SimpleTest shouldn't try to upload non files.
drewish - September 6, 2008 - 23:23
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | simpletest.module |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
Simple addition to check that a file is a file before we try to upload it. At least on OS X trying to upload a directory results in problems.
Some other trailing whitespace cleanups got rolled in by my editor.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| simpletest_real_files.patch | 2.56 KB | Idle | Unable to apply patch simpletest_real_files.patch | View details | Re-test |
#1
I removed white-space clean-up since that is in several other patches and the rework patch should make in soon (#305077: Rework simpletest backend).
The upload test doesn't pass with this applied.
#2
ah, seems like the order of operations was getting wacky. this passes all the uploading (upload.module, blogapi.module, user.module) tests.
#3
simple fix... still applies.
#4
Committed to HEAD. Thanks!
#5
Automatically closed -- issue fixed for two weeks with no activity.