Upgrading Tinymce

I didn't have problems with that, I could just replace my /sites/all/modules/tinymce/tinymce folder with the new version, and most things just worked.

Toggling the editor did not work anymore (I upgraded from TinyMCE 2.xx to 3.xx).

I changed lines 135-162 of tinymce.module to the following to make that work again:

$js_toggle = <<<EOD

  function mceToggle(id, linkid) {
    element = document.getElementById(id);
    link = document.getElementById(linkid);
    img_assist = document.getElementById('img_assist-link-'+ id);

    if (tinyMCE.getInstanceById(id) == null) {
      tinyMCE.execCommand('mceAddControl', false, id);
      element.togg = 'on';
      link.innerHTML = '$disable';
      link.href = "javascript:mceToggle('" +id+ "', '" +linkid+ "');";
      if (img_assist)
        img_assist.innerHTML = '';
      link.blur();
    }
    else {
      tinyMCE.execCommand('mceRemoveControl', false, id);
      element.togg = 'off';
      link.innerHTML = '$enable';
      link.href = "javascript:mceToggle('" +id+ "', '" +linkid+ "');";
      if (img_assist)
        img_assist.innerHTML = img_assist_default_link;
      link.blur();
    }
  }

EOD;

Also, the advimg (and I suppose the img module as well, I did not check that one) TinyMCE modules default to emitting style='align: right' type HTML code, which the Filtered HTML input filter in Drupal does not like: it strips out all 'style' attributes, even when the tag itself ( <img> for example) is allowed. Luckily, TinyMCE can be configured to use "old-style" HTML instead of inline styles.

What I did to solve this, is to append the following line under line 28 of plugin_reg.php:

$plugins['advimage']['inline_styles'] = array('false');

A better solution might be to either make this a configuration option, or to have this toggle along with the "Convert <font> tags to styles:" option in the configuration of the Drupal module. Note that you then have to modify plugin_reg.php as well, so TinyMCE allows style attributes on (for example) image tags:

$plugins['advimage']['extended_valid_elements'] = array('img[style|class|src|alt|title|hspace|vspace|width|height|align|onmouseover|onmouseout|name]');

Note that the toolbar button images are no longer shown alongside the various button options in the Drupal configuration page; cause of this is the fact that TinyMCE switched from a load of individual image files (one per button) to a single icons.gif file for all the button images. The Drupal module still tries to find all the individual images (and fails to do so). This doesn't impact functionality, as far as I have been able to figure out.

This version of TinyMCE is not supported anymore. The issue is closed for this reason.
Please upgrade to a supported version and feel free to reopen the issue on the new version if applicable.

This issue has been automagically closed by a script.