SpamSpan 6.x-1.0 seems to work well within my Drupal 6.4 test site. Without any other change, just updating with a new module version (6.x-1.1), emails are displayed as user [at] domain [dot] ext (instead of user@domain.ext, as until now, as well as in Drupal 5.10 - there also with latest version available...).

While this would somehow still be acceptable for me (even if weird, how the behavior suddenly changed...), clicking such a link opens e-mail message creation form with field "To" containing:
useruser@domain.extdomain.ext (yes, each part repeated twice, without a space or any other delimiter in between...). This for sure is unacceptable, as some inattentive user can easily send the message to a non-existing address...

The only filter beneath SpamSpan for my content type is Glossary filter, which if applied before SpamSpan (no change also when it is applied after...). The same Glossary filter is present in my (production) Drupal 5.10 system as well, creates no problems (also shouldn't interfere much considering its purpose) and is important for me (needed) at least as much as SpamSpan at the moment.

Comments

lakka’s picture

lakka commented
Assigned: Unassigned » lakka

Please can you tell me what the html source around the email address says?

Thanks

rc.otto’s picture

rc.otto commented

Hello,

unfortunately I have the same problem. The html source arond the email adress is like the following:

E-Mail: <span class="spamspan"><span class="u">kontakt</span> [at] <span class="d">domain [dot] eu</span><span class="t"><span class="spamspan"><span class="u">kontakt</span> [at] <span class="d">bnmp [dot] eu</span></span></span></span> </p>

or 

<div class="content clear-block">
    <p><img src="/images/image.gif"  hspace="5" vspace="5" width="100" height="126" align="right" /></p>
<p>some text<br />
more text.</p>
<p>more text</p>
<p>
Telefon : (number)<br />
Telefax : (number)<br />
E-Mail: <span class="spamspan"><span class="u">prename [dot] name</span> [at] <span class="d">domain [dot] eu</span><span class="t"><span class="spamspan"><span class="u">prename [dot] name</span> [at] <span class="d">domain [dot] eu</span></span></span></span></p>
  </div>

Any idea?

Rolf-Christian

lakka’s picture

lakka commented

Thanks for that.

1) Please can you tell me what the html says if spamspan is disabled?

2) Are you using a wysiwyg editor (FCKeditor, TinyMCE etc)?

3) In your list of input filters, are you using URL filter? If so, does it come after spamspan in the ordering?

luti’s picture

luti commented

HTML code in version 1.1 is:

<span class="spamspan">
   <span class="u">recipient</span> [at] <span class="d">domain [dot] ext</span>
   <span class="t">
      <span class="spamspan">
         <span class="u">recipient</span> [at] <span class="d">domain [dot] ext</span>
      </span>
   </span>
</span>

HTML code in version 1.0 (seems to work OK) was:

<span class="spamspan">
   <span class="u">recipient</span> [at] <span class="d">domain [dot] ext</span>
</span>
luti’s picture

luti commented

1. If spamspan is disabled, the code is:

<a href="mailto:recipient@domain.ext" title="Some Mouse Over Description">recipient@domain.ext</a>

Now I see that spamspan is "eating" the mail address title ("MouseOver" text), but this should probably be another issue...

2. I have Tiny Tiny MCE module enabled, but not for the code I am entering - the body of this node was written without this module being used. When just displaying a node, can this module interfere anyhow (there is no textarea or something like that, where it would be needed or enabled)?!

3. As stated already, the only input filter beside of spamspan is glossary...

rc.otto’s picture

rc.otto commented

1) html with disabled spamspan: 

<div class="content clear-block">
    <p><img src="/images/image.gif" hspace="5" vspace="5" width="100" height="126" align="right" /></p>
<p>some text,<br />
more text.</p>
<p>more text</p>
<p>
Telefon : (number)<br />
Telefax : (number)<br />
E-Mail: <a href="mailto:prename.name@domain.eu">prename.name@domain.eu</a></p>
  </div>

2) No, I am not using any wysiwyg editor.

3) I am using the following filters:

- URL-Filter (0)
- Zeilenumbruchkonverter (line break) (1)
- HTML-Korrektor (10)
- Hide email addresses (10)

The problem is the same, when I switch the HTML-Korrektor to 8.

lakka’s picture

lakka commented
Status: Closed (fixed) » Active

I've worked out what's happening.

1) You do not need to use a mailto: tag when you enter the address. Spamspan will automatically convert an address in plain text (i.e. just 

email@example.com

) into a clickable link

2) If you do use a mailto: link, which both of you are, and the content of the <a> tag is also the email address (i.e. as well as the the mailto: attribute), spamspan sees both email addresses and converts them both, with the result that you have seen.

I have, I hope fixed this in cvs (Drupal-6--1 branch). A new development release will come out in the next 12 hours or so, when the drupal packaging scripts are run. Please try this and tell me if it works for you. I will then create an official release. If you need the package sooner, send me a pm with your email address, and I will send you a tarball.

rc.otto’s picture

rc.otto commented

Thank You very much!

I do not use a mailto:-link, but Drupal does, because I am using the URL-filter, which is converting the email-adresses into mailto:-links. And - of course - the URL-filter is usefull. Without the URL-filter Spamspan seems to work faultless. So thank You very much for Your fix. I will try it soon.

rc.otto’s picture

rc.otto commented

spamspan-6.x-1.x-dev.tar.gz seems to work without problems. Thank You!

luti’s picture

luti commented

Seems to work now! Thx.

SaxxIng’s picture

SaxxIng commented

I can confirm that dev version seems fix the problem in 6.x-1.1 version.
Thanks for the rapid solution!
Regards,
Saxx

lakka’s picture

lakka commented
Status: Active » Fixed

Now fixed in 6.x-1.2

lakka’s picture

lakka commented
Status: Fixed » Closed (fixed)

Status: Active » Closed (fixed)

Correcting issue status, see #2125263: Issue status not taken from last comment during D7 migration.