what is the relevance of this? this is not good use of OO this is just name spacing with static classes and wrapping functionality that already exists. Not to mention then forcing users to use only the one .module file for a module preventing chunking into includes

Comments

brendoncrawford’s picture

brendoncrawford commented
Component: Code » Miscellaneous
Category: feature » task
Priority: Normal » Minor
Status: Active » Closed (won't fix)

Please don't assume that everyone shares your same opinions. Also, please do not waste module authors time with non-support issues. This is an issue tracker, not a soapbox. If you want to rant, do it on your blog. Thanks.

Also, here is the answer why: Because I want to.

robloach’s picture

robloach
he/him
commented
Title: why?? » Static Namespaces
Category: task » support
Status: Closed (won't fix) » Closed (works as designed)

Right now this module implements every hook as a static function, which isn't really object oriented. Here you're just namespacing hooks in static classes. What if every hook was instead of being statically implemented, it was overridden to be something when you wanted to implement that hook.....

brendoncrawford’s picture

brendoncrawford commented

Rob,

You can also extend/inherit classes, so they don't just operate solely as static containers.