i tried the toolbar setting a they not worked for a specifies setting.

Also a get an error message that I can only use 128 letter in the textbox.

CommentFileSizeAuthor
#4 openwysiwyg_1.patch13.71 KBdwees

Comments

omaigad’s picture

same problem

dwees’s picture

I've encountered the same problem, and am working on a solution. I have it 90% working and will hopefully post a patch within a day or so.

Actually I have it solved and am working on solving other problems (like the IMCE integration seems not to work either but that's a separate issue).

Dave

bennos’s picture

make a dev Version of the module and the community can make better test, with the latest bug fixes.

dwees’s picture

Status: Active » Needs review
StatusFileSize
new13.71 KB

Okay this is a patch with lots of changes in it, but unfortunately I don't have the older copies of the file to work with.

1. Version that is for download is missing the bug fixes discussed and committed earlier, this patch re-adds them.
- makes visibility settings savable
- trims spaces from the visibility settings
2. First effort to try and disable OpenWYSIWYG completely for Safari 2. Unfortunately this editor seems to hard crash Safari 2 every single time. :(
3. Added the ability to define a path to make the editor visible on. It still requires a look-up of the id of the textarea in question, but this would allow you to add an editor to the block admin page for instance.
4. Fixed the toolbar settings, you can now actually modify which buttons are available on a case by case basis.
5. Fixed a problem with the toolbar settings, variables in Drupal 5 are limited to 128 characters, so it was impossible to add more than a few buttons. Fixed this by aliasing the buttons with much shorter names for the purposes of saving the settings.
6. Some minor code style changes, haven't done through it with a fine tooth comb. I suggest installing and using the coder.module to run through this module and fix all of the stylistic changes.
7. Includes some code meant to work with the IMCE patch submitted for another issue ( see #305589: IMCE integration doesn't work ).

This patch does not address the issue of custom buttons not actually being added properly. Not sure how to implement this, and decided not to work on it too much since it's not a feature I was looking for.

bennos’s picture

Status: Needs review » Needs work

the new array in .module works with the defined keys, but the UI is broken.

The setting "b i u" produces the defined toolbar.

UI:
admin/settings/openwysiwyg
Toolbar settings
ad buttons:
here are a lot of array array array array array array array array array array array array array array array

Add lists:
here are the old UI and array settings, not the new ones.

the fontsize and the font select buttons are broken. there are two small.

dwees’s picture

Are you sure you've patched the file correctly? That seems like completely different behaviour than I have seen. I'll double check though and make sure it works.

Dave

bennos’s picture

something I have forgot. the patch file is broken in 196. this was the error message from patch.

I have patched the files manually. i will also check it and get you review

drupalnesia’s picture

Some path has been submit to new version:
5.x-1.2:
Bug Fix: escape space in textarea-id and content-type setting (by dwees)
Bug Fix: Visibility, no "Save confuguration" button (by zcc_nz)

I will check other patch and will submit ASAP. Thanks for submit patch.

drupalnesia’s picture

5.x-1.4:
[New] Built in Image File Browser!
5.x-1.13:
[New] Visibility: Show editor on specific pages
[New] Image Resize: Custom image resize, Proportional, new file name (you can downsize or upsize image!)
[Bug Fix] Support unlimited subfolder (depend on OS deep path setting)

I will take a look at the Toolbar issue.

drupalnesia’s picture

Status: Needs work » Closed (fixed)

5.x-1.14:
[New] Toolbar: separate toolbar setting for Toolbar1 and Toolbar2
[New] Toolbar: ACL for Toolbar Full and Toolbar Custom
[Bug Fix] Toolbar: fix Toolbar Setting does not work
[Bug Fix] Toolbar: change 'italics to italic', 'justify_full to justifyfull', 'inser_table to insertable ', etc.
[Bug Fix] Rename about_license.html to license.html

Features:

  1. Now you can define which group has "Toolbar button: full" or "Toolbar button:custom"
  2. You can add button by click and there are 2 separate text field for Toolbar 1 and Toolbar 2