looks interesting
tms - September 7, 2005 - 03:31
| Project: | Subscription |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | ee |
| Status: | closed |
Description
Looks interesting.
I've created a subscription.pgsql file for PostgreSQL users. You'll need to edit it to set the appropriate user your server runs as, if not "apache". Then su to postgres and
psql -d -f subscription.pgsql
I'm also cleaning up the messaging in the module file a little bit, the prose is a little fractured and there are some typos. I'll post a patch for that.
| Attachment | Size |
|---|---|
| subscription.pgsql | 875 bytes |
#1
I've take the liberty of cleaning up some of the messaging. Also fixed a definite bug in subscription_list() where a "." was used at the end of a line where a ";" was wanted, causing part of the message to repeat. (Kind of cool, actually, hadn't seen that one before. :-)
Suggestion: I'd rethink subscription_link. The way that it works now, you'll get the same "subscribe storys" link on the front page ten times. (Also, it should be "subscribe stories", but I didn't see an easy way to fix that, have to reword it to avoid
plurals.)
Still - looks interesting and I look forward to seeing this get "ready for prime time"!
#2
That "psql -d -f subscription.pgsql" should be
psql -d <your_db_name> -f subscription.pgsql#3
Thx,
(But I think seq-s in postgresql dump is unnecessary.
Drupal use db_next_id function.)
Thx for language patch, too.
#4
#5