Improve default user picture interface

Initial patch ready for review. Will need to re-roll if #142995: Add hook_file and make files into a 1st class Drupal object makes it in before this.

Forgot to add a form encoding type so the file would actually upload. Confirmed patch uploads, resizes and deletes default picture successfully.

I've tested this patch, and came across an error. On a fresh install (or when the user_pictures hasn't been enabled before) when there isn't a 'pictures' directory yet, this patch will upload the default picture before the goal directory has been created. Currently the directory is created after the entire form has been processed and is shown to the user again, while the uploaded file is moved to the goal directory during form validation.

I've attached a patch that fixes this, by creating the folder during the validation process. And +1 for this feature!

Thanks for that fix maartenvg! I modified it a little bit to use $form_state['values']['user_picture_path'] instead of variable_get since if the user is changing the picture path, that variable hasn't been saved yet. This also cleans up the 'picture_delete' and 'picture_upload' variables that unnecessarily get saved into $user->data from the user edit form.

Wow. This totally qualifies as one of those "duh" things that we completely overlook because we're all so used to Drupal working this way. Big +1 to seeing this fixed.

However, because this has gone unnoticed for 100s of years, it leads me to believe that this is a relatively obscure setting in Drupal that not many people use. And you know what that means? It means...... we need a test for it, because we're not likely to ever catch it if it breaks. ;)

Also, user_validate_default_picture needs some PHPDoc to satisfy my inner control freak. ;)

After discussion with webchick, need to:
- Add default user picture test to user.test
- Document the user_validate_default_picture function

And there's webchick's updated before mine...

Broadening issue a little to incorporate some fixes found in:
#131573: Validate maximum picture dimensions
#27234: Maximum picture size help text in profile no longer needed
#222036: Usability: Enabling user pictures is confusing
#141541: Files directory check doesn't disable uploads if check fails, in admin/user/settings

David, are you working on this or is it fine for me to start incorporating the other issues?

I've actually got most of the work done I just need to get some tests written today to wrap this up!

Will split out requiring image toolkit for user pictures to save a kitten and help me focus on this patch.

Subscribe

subscribe.