On investigation of the current integration between core, diff and revision moderation, I found the existing solution to be somewhat clumsy. The links on the admin interface currently point thusly:
http://example.com/node/18/revisions/22/view
The above link is generated by the revision moderation module, but it automatically points at the most recent revision (AFAICT). This is bad for two things: firstly, there could be more than one revision awaiting publication; secondly, there is no way to get from that part of the interface to the diff information, which (let's face it) is pretty handy when reviewing revisions. Otherwise, how can you tell what's changed?
Changing the code so that this module produces links thusly instead:
http://example.com/node/18/revisions
...means that you are instead taken to the revisions overview screen, where all the revisions exist, and you are automatically presented with diff information if that module is enabled. If it is not, you have a manual review process available instead.
Patch attached - patched against 6.x-1.x-dev - if it doesn't work, what you need to do is find function revision_moderation_pending_revisions_admin() and change this: (was line 322):
322c322
< l($node->title, "node/$node->nid/revisions/$node->vid/view"),
---
> l($node->title, "node/$node->nid/revisions"),
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | rev_mod-diff-love_306033-6.patch | 5.25 KB | add1sun |
| rev_mod.patch.txt | 140 bytes | niklp |
Comments
Comment #1
Jaap Haitsma commentedSubscribing to this issue. I'd like to see this in
Comment #2
asugene commentedExactly what I was looking for. Thanks for the patch. The two modules working together would be amazing.
Comment #3
niklp commentedIt works ok for me, but Addison is obviously too busy to get to review the patch and/or commit it, so if any users can confirm that its more useful than before with this patch, then give it a plus one and a review if possible, thanks.
Furthermore, there are some workflow oddities that need to be sorted, see elsewhere in this thread (re new nodes should be revisions). I have a solution to this, but it might not be to everyone's taste. I will be posting an article about that when I'm sure it's workable. It will be based on this module, diff and a combination of Views and Views_bulk_operations, to make a new content management interface and basic workflow.
Comment #4
add1sun commentedJust a note that the list of action links for the dsm has changed. that patch originally had some Diff links in it which I did not commit, so you may want to peak at that patch to see the Diff stuff it added. #312198: revision_moderation_nodeapi sets multiple messages plus better diff.module integration
Comment #5
niklp commentedI had a peek at the other thread. It doesn't appear that the two patches conflict. Hopefully I have already stated above why my patch is useful, and that it degrades elegantly with the diff.module being present.
Frankly it makes little sense not to commit this one, because the workflow without it just seems broken; only a link to the latest two revisions is presented, rather than a list of all revisions (which is where the diff stuff is presented). I'd probably suggest this modification even if diff *wasn't* available - hence there's no check for it in the patch.
Comment #6
add1sun commentedHere is a patch (using -up like it should ;-) though it does have some white-space cleanup as well) that combines both of these features: Go to the main revision page for a node from the pending revisions list and add a compare revisions link to the operation links that are listed when viewing a revision.
I'll probably go ahead and commit this later tonight or tomorrow.
Comment #7
add1sun commentedCommitted to 6 and HEAD.
Comment #8
asugene commentedCan this be added to 5x-1.2?