Using trigger and node option results in two revisions

NikLP - September 9, 2008 - 20:02
Project:Revision Moderation
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:active
Description

I'm glad this was so easy to identify - it actually relates to another bug that I was going to report (doubled up interface elements).

This module comes with two ways to enabled revision moderation: via a global trigger, which forces a moderated revision for every edit of every type, and also a per-node-type setting on the node edit form.

Currently, there is no automated check to see if mechanism 'a' is enabled when mechanism 'b' fires. Consequently, if both are enabled, two identical revisions are created on submission of the node form.

I am not aware if it is possible to check for an enabled trigger within another part of the module code, but initial investigations lean me towards proposing a check for this in revision_moderation_form_alter().

 
 

Drupal is a registered trademark of Dries Buytaert.