Nobody ever means to have whitespace as their feed pattern. We should trim it prior to doing anything with it.

Also $feedappend -> $feed_append

CommentFileSizeAuthor
feed_append_trim_naming.patch2.12 KBgreggles

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Any review? Should I just commit this?

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Seems valid, although it makes more sense to trim when the variables are saved so we can skip this in processing.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

That's true, though I think modifying them when they are saved is a bit more work, right?

Status: Needs review » Needs work

The last submitted patch, feed_append_trim_naming.patch, failed testing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

It's a bit more code, but if theres bulk operations or multiple aliases being saved, that trim() is run every, single time. So anything to help make normal operations go faster is a plus. But then again, this is a minor thing. We can make a new issue for trimming all patterns, etc. when saving the settings page.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Fixed

This was slipped in as a part of a recent commit.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.