Primary Links

hopfrog - September 11, 2008 - 08:27
Project:litejazz
Version:6.x-1.7
Component:User interface
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs review
Description

The primary links position on varied levels. The photograph cited explains better. How can I resolve? Thanks

AttachmentSize
Schermata.png21.88 KB

#1

lutchrd - September 11, 2008 - 12:17

Yup. Same issue observed.

#2

roopletheme - September 11, 2008 - 19:22

Oops. Looks like it's coming from a padding property in system-menus.css. My quick testing leads me to believe that adding the following code to style.css will resolve this issue:

#primary li.leaf {
  padding: 0;
}

Any chance one of you can confirm this? I'll update the repository as soon as I get some type of confirmation from someone seeing the problem.

#3

preyer - September 12, 2008 - 16:09

Confirmed. Adding that code to the end of the style.css file corrected the error for me in firefox, chrome and IE.

#4

hopfrog - September 12, 2008 - 16:54

No. The problem is not solved

#5

roopletheme - September 12, 2008 - 19:09
Status:active» postponed (maintainer needs more info)

Thanks for the feedback.

Not sure what to tell you, hopfrog... this css code fixes things for me on all browsers, and it seems to have fixed things for other users. Are you sure you've cleared your browser cache after changing the CSS code? Is it possible to post a link to your site?

#6

hopfrog - September 13, 2008 - 08:41

The site is: www.hopfrog.it - There is in course of passage from Drupal 5 to Drupal 6. Is it able to be this the motive?

#7

roopletheme - September 14, 2008 - 08:55

Hey, you switched themes on me before I could take a look! :)

#8

hopfrog - September 14, 2008 - 10:26

I was seeking other solutions and doing alterations. Now it is again online

#9

roopletheme - September 14, 2008 - 10:29

It seems that because I am an anonymous user, I only see the Home link in the primary links menu. With only one menu item, I cannot see the problem.

#10

hopfrog - September 14, 2008 - 13:55

It excuses for this small misunderstanding. I removed the primary link not having resolved the problem. Now there are again. I cite the photograph of the menu and the css changed: I think to serve and... thanks for the availability.

AttachmentSize
Schermata.png 108.41 KB
style.css_.pdf 8.17 KB

#11

roopletheme - September 14, 2008 - 22:27

Looks like one more CSS definition is in order:

#primary li.collapsed {
  padding:0;
}

#12

hopfrog - September 15, 2008 - 05:55

Perfect! It works very well and the problem is resolved.

#13

majorxp - October 26, 2008 - 02:35

I had the exact issue and adding both definitions resolved the issue.

#14

audihertz - October 29, 2008 - 21:44

I can confirm this fix as well. Thanks!

#15

freixas - January 6, 2009 - 21:53

I just ran into this problem, even after adding

#primary li.leaf, #primary li.collapsed { padding: 0 }

to styles.css.

After comparing 6.x-1.7 LiteJazz to Drupal 6.8's Garland theme, I changed

    <?php if ($primary_links): ?>
    <div id="primary" class="clear-block"> <?php print theme('menu_tree', menu_tree('primary-links')); ?> </div>
    <?php endif; ?>
    <?php if ($secondary_links): ?>
    <div id="secondary" class="clear-block"> <?php print theme('menu_links', $secondary_links); ?> </div>
    <?php endif; ?>

to

  <?php if (isset($primary_links)) : ?>
  <div id="primary" class="clear-block"> <?php print theme('links', $primary_links, array('class' => 'primary-links')) ?></div>
  <?php endif; ?>
  <?php if (isset($secondary_links)) : ?>
  <div id="secondary" class="clear-block"><?php print theme('links', $secondary_links, array('class' => 'secondary-links')) ?></div>
  <?php endif; ?>

in page.tpl.php.

I had the primary links assigned as the source for both the primary and secondary navigation.

Without this change,

  • The primary links were still including the sub-menus
  • The secondary links were empty

After the change, these two problems were fixed. I can't guarantee that this change won't break some other option—I'm not sure that the HTML generated by the new code is exactly the same as the HTML generated by the old code.

#16

goodeit - May 13, 2009 - 16:02

I applied the fixes mentioned in #2 and #11 and it seems to work great now in FF and IE 6 and 7. I am not using suckerfish menus and have no secondary links.

Thanks!

#17

murokoma - October 4, 2009 - 05:07

Hmmm, stranegly enough, this doesn't work for me - added both css snippets, uploaded, refreshed; nothing. Does not work in IE 8 and FF 3.5, eiter.

Menu system *would* work if I was using primary links within suckerfish area; however, I do NOT want to use suckerfish menus for themeing reasons and rather keep the "regular" primary links.

Any idea? I attached a screenshot (above red line is unexpanded, below when expanded- it breaks after "Schritt-für-Schritt Anleitungen").

Thanks!
R.

AttachmentSize
litejazz_menu_bug.jpg 32.92 KB

#18

murokoma - October 4, 2009 - 05:47
Status:postponed (maintainer needs more info)» needs review
 
 

Drupal is a registered trademark of Dries Buytaert.