I get the notice: Undefined index: HTTP_X_DRUPAL_RENDER_MODE in C:\xampp\htdocs\trunk\sites\all\modules\popups\popups.module on line 83.

I can not find any place in the Drupal code where this $_SERVER['HTTP_X_DRUPAL_RENDER_MODE'] is set.

CommentFileSizeAuthor
#2 popups.patch748 bytesgustav

Comments

starbow’s picture

starbow commented
Assigned: Unassigned » starbow
Priority: Normal » Minor

You must have a pretty strict php warning level. That global is set by PHP itself in response to the HTTP header. I will put in an isset test.

gustav’s picture

gustav commented
Title: HTTP_X_DRUPAL_RENDER_MODE not set anywhere » PHP Notice when HTTP_X_DRUPAL_RENDER_MODE is not set
Status: Active » Needs review
StatusFileSize
new popups.patch748 bytes

The isset test only moves the notice to later when $render_mode is used. The attached patch removes the notice altogether.

starbow’s picture

starbow commented
Status: Needs review » Fixed

Whoops, missed this in RC2, but it is in dev.

eMPee584’s picture

eMPee584 commented
Version: 6.x-1.1-beta4 » 6.x-1.1-rc4
Status: Fixed » Reviewed & tested by the community

This patch is not in the current RC.

starbow’s picture

starbow commented
Status: Reviewed & tested by the community » Fixed

Weird. You are right.
I have checked it into dev again.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.